[libvirt] [PATCH] small fixes in storage_conf.c
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
Hi,
These patches fix:
- missing VIR_FREE for the return value of virXPathString
- wrong error message "missing owner element" where should be "missing
group element"
Signed-off-by: Ryota Ozaki <ozaki.ryota(a)gmail.com>
Attachments:
- 0002-fix-error-message.patch (application/octet-stream — 849 bytes)
- 0001-fix-missing-VIR_FREE.patch (application/octet-stream — 1.1 KB)
Ryota Ozaki wrote:
These patches fix:
- missing VIR_FREE for the return value of virXPathString
- wrong error message "missing owner element" where should be "missing
group element"
Thank you!
Both of those are fine.
I'll apply them today.
FYI, looking at the first one, I spotted another problem.
Since strtol dereferences its 2nd parameter when it's non-NULL,
it must always be initialized.
I'll post that fix separately.
On Mon, Mar 02, 2009 at 10:13:11AM +0100, Jim Meyering wrote:
Ryota Ozaki wrote:
> These patches fix:
> - missing VIR_FREE for the return value of virXPathString
> - wrong error message "missing owner element" where should be
"missing
> group element"
Thank you!
Both of those are fine.
Agreed, I was about to commit them myself !
I'll apply them today.
please go ahead !
FYI, looking at the first one, I spotted another problem.
Since strtol dereferences its 2nd parameter when it's non-NULL,
it must always be initialized.
I'll post that fix separately.
okay if it's trivial please commit, as I would like to make a 0.6.1
release soon, hopefully today
thanks,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
Daniel Veillard wrote:
On Mon, Mar 02, 2009 at 10:13:11AM +0100, Jim Meyering wrote:
> Ryota Ozaki wrote:
> > These patches fix:
> > - missing VIR_FREE for the return value of virXPathString
> > - wrong error message "missing owner element" where should be
"missing
> > group element"
>
> Thank you!
> Both of those are fine.
Agreed, I was about to commit them myself !
> I'll apply them today.
please go ahead !
Committed.
5744
days inactive
5745
days old
3 comments
3 participants
tags (0)
participants (3)
-
Daniel Veillard -
Jim Meyering -
Ryota Ozaki