[libvirt] Failing pool deletion testcase
Hi, when running libvirt-tck I'm seeing this test failure: # Failed test 'deleted pool' # at /usr/share/libvirt-tck/tests/storage/110-disk-pool.t line 120. # died: Sys::Virt::Error (libvirt error code: 3, message: this function is not supported by the connection driver: pool does not support pool deletion # ) because pool deletion isn't supported by the disk storage backend. Since the test is there I wonder if there are patches floating around already to implement it? If not I guess wiping the partition table followed by a "blockdev --reread-pt" would be the right approach? Cheers, -- Guido
On Sat, Nov 05, 2011 at 02:41:41PM +0100, Guido Günther wrote:
Hi, when running libvirt-tck I'm seeing this test failure:
# Failed test 'deleted pool' # at /usr/share/libvirt-tck/tests/storage/110-disk-pool.t line 120. # died: Sys::Virt::Error (libvirt error code: 3, message: this function is not supported by the connection driver: pool does not support pool deletion # )
because pool deletion isn't supported by the disk storage backend. Since the test is there I wonder if there are patches floating around already to implement it? If not I guess wiping the partition table followed by a "blockdev --reread-pt" would be the right approach?
Yeah, we just need to blow away the DOS and/or GPT partition table signatures and trigger a re-read by the kernel The "correct" way would be to use parted to clear it, the "quick" way would be to just write zeros over the relevant areas. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Hi Daniel, On Mon, Nov 07, 2011 at 09:56:39AM +0000, Daniel P. Berrange wrote:
On Sat, Nov 05, 2011 at 02:41:41PM +0100, Guido Günther wrote:
Hi, when running libvirt-tck I'm seeing this test failure:
# Failed test 'deleted pool' # at /usr/share/libvirt-tck/tests/storage/110-disk-pool.t line 120. # died: Sys::Virt::Error (libvirt error code: 3, message: this function is not supported by the connection driver: pool does not support pool deletion # )
because pool deletion isn't supported by the disk storage backend. Since the test is there I wonder if there are patches floating around already to implement it? If not I guess wiping the partition table followed by a "blockdev --reread-pt" would be the right approach?
Yeah, we just need to blow away the DOS and/or GPT partition table signatures and trigger a re-read by the kernel The "correct" way would be to use parted to clear it, the "quick" way would be to just write zeros over the relevant areas.
Yes, adding this to parted first makes even more sense. I'll add this to my TODO list. Cheers, -- Guido
participants (2)
-
Daniel P. Berrange -
Guido Günther