[Libvir] [PATCH] Remove warning when dumping XML from an inactive domain with Xen < 3.1
# virsh dumpxml solaris32fv libvir: Xen Daemon error : failed Xen syscall xenDaemonDomainDumpXML domain ID < 0 and xendConfigVersion < 3 0 [ and dump proceeds as normal ] The patch just removes the false error message and makes a note that this still needs a real fix later. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903
On Tue, Sep 04, 2007 at 05:21:41PM +0100, Richard W.M. Jones wrote:
# virsh dumpxml solaris32fv libvir: Xen Daemon error : failed Xen syscall xenDaemonDomainDumpXML domain ID < 0 and xendConfigVersion < 3 0 [ and dump proceeds as normal ]
The patch just removes the false error message and makes a note that this still needs a real fix later.
I understand the patch, but I disagree with removing the comment explaining the returned value for xenDaemonDomainDumpXMLByName() You ask to dump the XML for an inactive domain, on xen < 3.1 you can't do this there, maybe you don't want to see an error being raised but still the way the function works didn't changed, so keep that comment please :-) Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
On Tue, Sep 04, 2007 at 05:21:41PM +0100, Richard W.M. Jones wrote:
# virsh dumpxml solaris32fv libvir: Xen Daemon error : failed Xen syscall xenDaemonDomainDumpXML domain ID < 0 and xendConfigVersion < 3 0 [ and dump proceeds as normal ]
The patch just removes the false error message and makes a note that this still needs a real fix later.
ACK. I agree we should really change the dom id / config version checking to be done in xen_unified so we don't unneccessarily call drivers that we know can't handle it. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
Richard W.M. Jones wrote:
# virsh dumpxml solaris32fv libvir: Xen Daemon error : failed Xen syscall xenDaemonDomainDumpXML domain ID < 0 and xendConfigVersion < 3 0 [ and dump proceeds as normal ]
The patch just removes the false error message and makes a note that this still needs a real fix later.
This is committed, but as Daniel Veillard suggested I didn't remove that comment. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903
participants (3)
-
Daniel P. Berrange -
Daniel Veillard -
Richard W.M. Jones