[libvirt] [PATCHv2] build: increase xz compression level
Increase the default compression level to 9 from 6. This also increases decompression memory requirements from 9 MB to 65 MB. Also turn on verbosity. --- Makefile.am | 3 +++ 1 file changed, 3 insertions(+) v2: also use -v move the setting to Makefile.am diff --git a/Makefile.am b/Makefile.am index 4b4aad3..ef88067 100644 --- a/Makefile.am +++ b/Makefile.am @@ -22,6 +22,9 @@ GENHTML = genhtml SUBDIRS = . gnulib/lib include/libvirt src daemon tools docs gnulib/tests \ tests po examples +XZ_OPT ?= -9ev +export XZ_OPT + ACLOCAL_AMFLAGS = -I m4 EXTRA_DIST = \ -- 2.7.3
On Fri, Jun 24, 2016 at 03:07:01PM +0200, Ján Tomko wrote:
Increase the default compression level to 9 from 6.
This also increases decompression memory requirements from 9 MB to 65 MB.
Also turn on verbosity. --- Makefile.am | 3 +++ 1 file changed, 3 insertions(+)
v2: also use -v move the setting to Makefile.am
diff --git a/Makefile.am b/Makefile.am index 4b4aad3..ef88067 100644 --- a/Makefile.am +++ b/Makefile.am @@ -22,6 +22,9 @@ GENHTML = genhtml SUBDIRS = . gnulib/lib include/libvirt src daemon tools docs gnulib/tests \ tests po examples
+XZ_OPT ?= -9ev +export XZ_OPT
This is a make variable, not shell, so 'export XZ_OPT' is not relevant AFAICT. ACK if that line is removed. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On Fri, Jun 24, 2016 at 02:30:54PM +0100, Daniel P. Berrange wrote:
On Fri, Jun 24, 2016 at 03:07:01PM +0200, Ján Tomko wrote:
Increase the default compression level to 9 from 6.
This also increases decompression memory requirements from 9 MB to 65 MB.
Also turn on verbosity. --- Makefile.am | 3 +++ 1 file changed, 3 insertions(+)
v2: also use -v move the setting to Makefile.am
diff --git a/Makefile.am b/Makefile.am index 4b4aad3..ef88067 100644 --- a/Makefile.am +++ b/Makefile.am @@ -22,6 +22,9 @@ GENHTML = genhtml SUBDIRS = . gnulib/lib include/libvirt src daemon tools docs gnulib/tests \ tests po examples
+XZ_OPT ?= -9ev +export XZ_OPT
This is a make variable, not shell, so 'export XZ_OPT' is not relevant AFAICT.
It does not work without export. I don't know whether it's needed to propagate the value to a sub-Makefile or automake expects it to be a shell variable when executing the command: tardir=libvirt-2.0.0 && tar --format=posix -chf - "$tardir" | XZ_OPT=${XZ_OPT--e} xz -c >libvirt-2.0.0.tar.xz Jan
ACK if that line is removed.
Regards, Daniel
On Fri, Jun 24, 2016 at 03:47:24PM +0200, Ján Tomko wrote:
On Fri, Jun 24, 2016 at 02:30:54PM +0100, Daniel P. Berrange wrote:
On Fri, Jun 24, 2016 at 03:07:01PM +0200, Ján Tomko wrote:
Increase the default compression level to 9 from 6.
This also increases decompression memory requirements from 9 MB to 65 MB.
Also turn on verbosity. --- Makefile.am | 3 +++ 1 file changed, 3 insertions(+)
v2: also use -v move the setting to Makefile.am
diff --git a/Makefile.am b/Makefile.am index 4b4aad3..ef88067 100644 --- a/Makefile.am +++ b/Makefile.am @@ -22,6 +22,9 @@ GENHTML = genhtml SUBDIRS = . gnulib/lib include/libvirt src daemon tools docs gnulib/tests \ tests po examples
+XZ_OPT ?= -9ev +export XZ_OPT
This is a make variable, not shell, so 'export XZ_OPT' is not relevant AFAICT.
It does not work without export.
I don't know whether it's needed to propagate the value to a sub-Makefile or automake expects it to be a shell variable when executing the command:
tardir=libvirt-2.0.0 && tar --format=posix -chf - "$tardir" | XZ_OPT=${XZ_OPT--e} xz -c >libvirt-2.0.0.tar.xz
Ah OK then. ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
participants (2)
-
Daniel P. Berrange -
Ján Tomko