[libvirt] [PATCH] sanlock: Avoid freeing uninitialized value
https://bugzilla.redhat.com/show_bug.cgi?id=1136788 Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- src/locking/lock_driver_sanlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/locking/lock_driver_sanlock.c b/src/locking/lock_driver_sanlock.c index aade437..aa6b8fb 100644 --- a/src/locking/lock_driver_sanlock.c +++ b/src/locking/lock_driver_sanlock.c @@ -885,7 +885,7 @@ static int virLockManagerSanlockAcquire(virLockManagerPtr lock, int *fd) { virLockManagerSanlockPrivatePtr priv = lock->privateData; - struct sanlk_options *opt; + struct sanlk_options *opt = NULL; struct sanlk_resource **res_args; int res_count; bool res_free = false; -- 2.1.0
On 09/03/2014 05:26 AM, Jiri Denemark wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1136788 Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- src/locking/lock_driver_sanlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK
diff --git a/src/locking/lock_driver_sanlock.c b/src/locking/lock_driver_sanlock.c index aade437..aa6b8fb 100644 --- a/src/locking/lock_driver_sanlock.c +++ b/src/locking/lock_driver_sanlock.c @@ -885,7 +885,7 @@ static int virLockManagerSanlockAcquire(virLockManagerPtr lock, int *fd) { virLockManagerSanlockPrivatePtr priv = lock->privateData; - struct sanlk_options *opt; + struct sanlk_options *opt = NULL; struct sanlk_resource **res_args; int res_count; bool res_free = false;
-- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On Wed, Sep 03, 2014 at 01:26:08PM +0200, Jiri Denemark wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1136788 Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- src/locking/lock_driver_sanlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Trivial, ACK. Martin
diff --git a/src/locking/lock_driver_sanlock.c b/src/locking/lock_driver_sanlock.c index aade437..aa6b8fb 100644 --- a/src/locking/lock_driver_sanlock.c +++ b/src/locking/lock_driver_sanlock.c @@ -885,7 +885,7 @@ static int virLockManagerSanlockAcquire(virLockManagerPtr lock, int *fd) { virLockManagerSanlockPrivatePtr priv = lock->privateData; - struct sanlk_options *opt; + struct sanlk_options *opt = NULL; struct sanlk_resource **res_args; int res_count; bool res_free = false; -- 2.1.0
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
participants (3)
-
Eric Blake -
Jiri Denemark -
Martin Kletzander