[libvirt] Libvirt 0.9.2 week freeze, RC1 version to test
So we are entering the week freeze for the new version. I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.2-rc1.tar.gz I also made rpms too for those interested. I didn't included the locking patches from Dan Berrange, though I had given a review and ACK on the previous version. Maybe we can push this soon and then I will made an rc2. It would be nice to try to identify the OpenSolaris portability issues,a dn if someone could give it a try on Win32 that would be great (along other linux builds of course !) I have tried it locally and basic operations seems to work fine, please give it a try too. thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
2011/5/29 Daniel Veillard <veillard@redhat.com>:
So we are entering the week freeze for the new version. I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.2-rc1.tar.gz I also made rpms too for those interested. I didn't included the locking patches from Dan Berrange, though I had given a review and ACK on the previous version. Maybe we can push this soon and then I will made an rc2. It would be nice to try to identify the OpenSolaris portability issues,a dn if someone could give it a try on Win32 that would be great (along other linux builds of course !)
I have tried it locally and basic operations seems to work fine, please give it a try too.
thanks !
Daniel
Works on Ubuntu 10.04, Windows (MinGW) and FreeBSD. Matthias
On Wed, Jun 1, 2011 at 10:31, Matthias Bolte <matthias.bolte@googlemail.com> wrote:
2011/5/29 Daniel Veillard <veillard@redhat.com>:
So we are entering the week freeze for the new version. I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.2-rc1.tar.gz I also made rpms too for those interested. I didn't included the locking patches from Dan Berrange, though I had given a review and ACK on the previous version. Maybe we can push this soon and then I will made an rc2. It would be nice to try to identify the OpenSolaris portability issues,a dn if someone could give it a try on Win32 that would be great (along other linux builds of course !)
I have tried it locally and basic operations seems to work fine, please give it a try too.
thanks !
Daniel
Works on Ubuntu 10.04, Windows (MinGW) and FreeBSD.
Matthias
Works on OSX 10.7.0, tested with VirtualBox 4.08 Ruben
I just pushed a second release candidate ftp://libvirt.org/libvirt/libvirt-0.9.2-rc2.tar.gz with corresponding rpm builds, this includes the extrenal lock support. On Wed, Jun 01, 2011 at 12:49:52PM +0200, Ruben Kerkhof wrote:
On Wed, Jun 1, 2011 at 10:31, Matthias Bolte <matthias.bolte@googlemail.com> wrote:
Works on Ubuntu 10.04, Windows (MinGW) and FreeBSD.
Matthias
Works on OSX 10.7.0, tested with VirtualBox 4.08
Excellent news, thanks ! I hope we didn't introduced regressions in portability with the latest API additions ! If people could also try -rc2 it would be great too, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
On Thu, Jun 2, 2011 at 15:05, Daniel Veillard <veillard@redhat.com> wrote:
I just pushed a second release candidate ftp://libvirt.org/libvirt/libvirt-0.9.2-rc2.tar.gz with corresponding rpm builds, this includes the extrenal lock support.
On Wed, Jun 01, 2011 at 12:49:52PM +0200, Ruben Kerkhof wrote:
On Wed, Jun 1, 2011 at 10:31, Matthias Bolte <matthias.bolte@googlemail.com> wrote:
Works on Ubuntu 10.04, Windows (MinGW) and FreeBSD.
Matthias
Works on OSX 10.7.0, tested with VirtualBox 4.08
Excellent news, thanks ! I hope we didn't introduced regressions in portability with the latest API additions ! If people could also try -rc2 it would be great too,
thanks !
Daniel
Still works on OSX. This time I had to remove the --with-openvz option from the Homebrew formula. Ruben
On 06/02/2011 07:45 AM, Ruben Kerkhof wrote:
If people could also try -rc2 it would be great too,
thanks !
Daniel
Still works on OSX. This time I had to remove the --with-openvz option from the Homebrew formula.
Why were you using --with-openvz in the first place? Does OpenVZ work on OSX, in which case commit e85a602b represents a regression for restricting it to Linux-only? Or did you have a typo, where you meant that you previously had to use --without-openvz, and now you no longer need to because the configure.ac patch did the right thing? -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Hi Eric, On Thu, Jun 2, 2011 at 16:06, Eric Blake <eblake@redhat.com> wrote:
Why were you using --with-openvz in the first place?
You have to ask Justin, I used his Homebrew formula :-). It's always been in there I think.
Does OpenVZ work on OSX, in which case commit e85a602b represents a regression for restricting it to Linux-only? Or did you have a typo, where you meant that you previously had to use --without-openvz, and now you no longer need to because the configure.ac patch did the right thing?
No, e85a602b does the right thing. Justin is going to update the formula. Kind regards, Ruben
2011/6/2 Daniel Veillard <veillard@redhat.com>:
I just pushed a second release candidate ftp://libvirt.org/libvirt/libvirt-0.9.2-rc2.tar.gz with corresponding rpm builds, this includes the extrenal lock support.
On Wed, Jun 01, 2011 at 12:49:52PM +0200, Ruben Kerkhof wrote:
On Wed, Jun 1, 2011 at 10:31, Matthias Bolte <matthias.bolte@googlemail.com> wrote:
Works on Ubuntu 10.04, Windows (MinGW) and FreeBSD.
Matthias
Works on OSX 10.7.0, tested with VirtualBox 4.08
Excellent news, thanks ! I hope we didn't introduced regressions in portability with the latest API additions ! If people could also try -rc2 it would be great too,
thanks !
Daniel
RC2 is broken on MinGW due to the lock manager using dlopen unconditional. The attached patch fixes it. Still works on FreeBSD and Ubuntu 10.04. Matthias
On Fri, Jun 03, 2011 at 01:27:04PM +0200, Matthias Bolte wrote:
2011/6/2 Daniel Veillard <veillard@redhat.com>:
I just pushed a second release candidate ftp://libvirt.org/libvirt/libvirt-0.9.2-rc2.tar.gz with corresponding rpm builds, this includes the extrenal lock support.
On Wed, Jun 01, 2011 at 12:49:52PM +0200, Ruben Kerkhof wrote:
On Wed, Jun 1, 2011 at 10:31, Matthias Bolte <matthias.bolte@googlemail.com> wrote:
Works on Ubuntu 10.04, Windows (MinGW) and FreeBSD.
Matthias
Works on OSX 10.7.0, tested with VirtualBox 4.08
Excellent news, thanks ! I hope we didn't introduced regressions in portability with the latest API additions ! If people could also try -rc2 it would be great too,
thanks !
Daniel
RC2 is broken on MinGW due to the lock manager using dlopen unconditional. The attached patch fixes it.
Argh, ACK, please push
Still works on FreeBSD and Ubuntu 10.04.
okay :-) Thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
On Fri, Jun 03, 2011 at 01:27:04PM +0200, Matthias Bolte wrote:
2011/6/2 Daniel Veillard <veillard@redhat.com>:
I just pushed a second release candidate ftp://libvirt.org/libvirt/libvirt-0.9.2-rc2.tar.gz with corresponding rpm builds, this includes the extrenal lock support.
On Wed, Jun 01, 2011 at 12:49:52PM +0200, Ruben Kerkhof wrote:
On Wed, Jun 1, 2011 at 10:31, Matthias Bolte <matthias.bolte@googlemail.com> wrote:
Works on Ubuntu 10.04, Windows (MinGW) and FreeBSD.
Matthias
Works on OSX 10.7.0, tested with VirtualBox 4.08
Excellent news, thanks ! I hope we didn't introduced regressions in portability with the latest API additions ! If people could also try -rc2 it would be great too,
thanks !
Daniel
RC2 is broken on MinGW due to the lock manager using dlopen unconditional. The attached patch fixes it.
Still works on FreeBSD and Ubuntu 10.04.
Matthias
From c734e683c4d9bbb5a87fba3e0008ce8000b62fe5 Mon Sep 17 00:00:00 2001 From: Matthias Bolte <matthias.bolte@googlemail.com> Date: Fri, 3 Jun 2011 10:20:49 +0200 Subject: [PATCH] Make dlopen usage in lock manager conditional
This fixes build failure on MinGW, due to MinGW not supporting dlopen. --- src/locking/lock_manager.c | 20 +++++++++++++++++++- 1 files changed, 19 insertions(+), 1 deletions(-)
diff --git a/src/locking/lock_manager.c b/src/locking/lock_manager.c index 6197fd4..6293e6d 100644 --- a/src/locking/lock_manager.c +++ b/src/locking/lock_manager.c @@ -29,7 +29,9 @@ #include "memory.h" #include "uuid.h"
-#include <dlfcn.h> +#if HAVE_DLFCN_H +# include <dlfcn.h> +#endif #include <stdlib.h> #include <unistd.h>
@@ -115,6 +117,7 @@ static void virLockManagerLogParams(size_t nparams, * * Returns a plugin object, or NULL if loading failed. */ +#if HAVE_DLFCN_H virLockManagerPluginPtr virLockManagerPluginNew(const char *name, unsigned int flags) { @@ -187,6 +190,15 @@ cleanup: dlclose(handle); return NULL; } +#else /* !HAVE_DLFCN_H */ +virLockManagerPluginPtr virLockManagerPluginNew(const char *name ATTRIBUTE_UNUSED, + unsigned int flags ATTRIBUTE_UNUSED) +{ + virLockError(VIR_ERR_INTERNAL_ERROR, "%s", + _("this platform is missing dlopen")); + return NULL; +} +#endif /* !HAVE_DLFCN_H */
/** @@ -211,6 +223,7 @@ void virLockManagerPluginRef(virLockManagerPluginPtr plugin) * result in an unsafe scenario. * */ +#if HAVE_DLFCN_H void virLockManagerPluginUnref(virLockManagerPluginPtr plugin) { if (!plugin) @@ -232,6 +245,11 @@ void virLockManagerPluginUnref(virLockManagerPluginPtr plugin) VIR_FREE(plugin->name); VIR_FREE(plugin); } +#else /* !HAVE_DLFCN_H */ +void virLockManagerPluginUnref(virLockManagerPluginPtr plugin ATTRIBUTE_UNUSED) +{ +} +#endif /* !HAVE_DLFCN_H */
const char *virLockManagerPluginGetName(virLockManagerPluginPtr plugin)
ACK, I hit this yesterday but ran out of time to fix it Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
2011/6/3 Daniel P. Berrange <berrange@redhat.com>:
On Fri, Jun 03, 2011 at 01:27:04PM +0200, Matthias Bolte wrote:
2011/6/2 Daniel Veillard <veillard@redhat.com>:
I just pushed a second release candidate ftp://libvirt.org/libvirt/libvirt-0.9.2-rc2.tar.gz with corresponding rpm builds, this includes the extrenal lock support.
On Wed, Jun 01, 2011 at 12:49:52PM +0200, Ruben Kerkhof wrote:
On Wed, Jun 1, 2011 at 10:31, Matthias Bolte <matthias.bolte@googlemail.com> wrote:
Works on Ubuntu 10.04, Windows (MinGW) and FreeBSD.
Matthias
Works on OSX 10.7.0, tested with VirtualBox 4.08
Excellent news, thanks ! I hope we didn't introduced regressions in portability with the latest API additions ! If people could also try -rc2 it would be great too,
thanks !
Daniel
RC2 is broken on MinGW due to the lock manager using dlopen unconditional. The attached patch fixes it.
Still works on FreeBSD and Ubuntu 10.04.
Matthias
From c734e683c4d9bbb5a87fba3e0008ce8000b62fe5 Mon Sep 17 00:00:00 2001 From: Matthias Bolte <matthias.bolte@googlemail.com> Date: Fri, 3 Jun 2011 10:20:49 +0200 Subject: [PATCH] Make dlopen usage in lock manager conditional
This fixes build failure on MinGW, due to MinGW not supporting dlopen. --- src/locking/lock_manager.c | 20 +++++++++++++++++++- 1 files changed, 19 insertions(+), 1 deletions(-)
diff --git a/src/locking/lock_manager.c b/src/locking/lock_manager.c index 6197fd4..6293e6d 100644 --- a/src/locking/lock_manager.c +++ b/src/locking/lock_manager.c @@ -29,7 +29,9 @@ #include "memory.h" #include "uuid.h"
-#include <dlfcn.h> +#if HAVE_DLFCN_H +# include <dlfcn.h> +#endif #include <stdlib.h> #include <unistd.h>
@@ -115,6 +117,7 @@ static void virLockManagerLogParams(size_t nparams, * * Returns a plugin object, or NULL if loading failed. */ +#if HAVE_DLFCN_H virLockManagerPluginPtr virLockManagerPluginNew(const char *name, unsigned int flags) { @@ -187,6 +190,15 @@ cleanup: dlclose(handle); return NULL; } +#else /* !HAVE_DLFCN_H */ +virLockManagerPluginPtr virLockManagerPluginNew(const char *name ATTRIBUTE_UNUSED, + unsigned int flags ATTRIBUTE_UNUSED) +{ + virLockError(VIR_ERR_INTERNAL_ERROR, "%s", + _("this platform is missing dlopen")); + return NULL; +} +#endif /* !HAVE_DLFCN_H */
/** @@ -211,6 +223,7 @@ void virLockManagerPluginRef(virLockManagerPluginPtr plugin) * result in an unsafe scenario. * */ +#if HAVE_DLFCN_H void virLockManagerPluginUnref(virLockManagerPluginPtr plugin) { if (!plugin) @@ -232,6 +245,11 @@ void virLockManagerPluginUnref(virLockManagerPluginPtr plugin) VIR_FREE(plugin->name); VIR_FREE(plugin); } +#else /* !HAVE_DLFCN_H */ +void virLockManagerPluginUnref(virLockManagerPluginPtr plugin ATTRIBUTE_UNUSED) +{ +} +#endif /* !HAVE_DLFCN_H */
const char *virLockManagerPluginGetName(virLockManagerPluginPtr plugin)
ACK, I hit this yesterday but ran out of time to fix it
Daniel
Thanks, pushed. Matthias
participants (5)
-
Daniel P. Berrange -
Daniel Veillard -
Eric Blake -
Matthias Bolte -
Ruben Kerkhof