[libvirt] [PATCH] docs: Remove useless p:first-line CSS rule
According to MDN[1], the 'margin-left' CSS property cannot be applied to the '::first-line' pseudo-element, so this rule will never have any effect and can be safely removed. [1] https://developer.mozilla.org/en/docs/Web/CSS/::first-line --- docs/generic.css | 4 ---- 1 file changed, 4 deletions(-) diff --git a/docs/generic.css b/docs/generic.css index 4f98b26..208e31e 100644 --- a/docs/generic.css +++ b/docs/generic.css @@ -7,10 +7,6 @@ body { background: #ffffff; } -p:first-line { - margin-right: 1em; -} - p, ul, ol, dl { padding: 0px; margin: 0px; -- 2.5.5
On Fri, Apr 01, 2016 at 11:35:09AM +0200, Andrea Bolognani wrote:
According to MDN[1], the 'margin-left' CSS property cannot be
... left ...
applied to the '::first-line' pseudo-element, so this rule will never have any effect and can be safely removed.
[1] https://developer.mozilla.org/en/docs/Web/CSS/::first-line --- docs/generic.css | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/docs/generic.css b/docs/generic.css index 4f98b26..208e31e 100644 --- a/docs/generic.css +++ b/docs/generic.css @@ -7,10 +7,6 @@ body { background: #ffffff; }
-p:first-line { - margin-right: 1em;
... right ... ???
-} - p, ul, ol, dl { padding: 0px; margin: 0px; -- 2.5.5
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, 2016-04-01 at 13:04 +0200, Martin Kletzander wrote:
On Fri, Apr 01, 2016 at 11:35:09AM +0200, Andrea Bolognani wrote:
According to MDN[1], the 'margin-left' CSS property cannot be ... left ... applied to the '::first-line' pseudo-element, so this rule will never have any effect and can be safely removed. [1] https://developer.mozilla.org/en/docs/Web/CSS/::first-line --- docs/generic.css | 4 ---- 1 file changed, 4 deletions(-) diff --git a/docs/generic.css b/docs/generic.css index 4f98b26..208e31e 100644 --- a/docs/generic.css +++ b/docs/generic.css @@ -7,10 +7,6 @@ body { background: #ffffff; } -p:first-line { - margin-right: 1em; ... right ... ???
It makes even less sense that way, doesn't it? I get wanting to have a bigger left margin for the first line, but why would you even want to have a bigger *right* margin? In any case, the MDN page clearly states that only a small subset of CSS properties can be used for the ::first-line pseudo-element, and the margin-* are not among those. So consider the commit message fixed: the change itself is still desiderable :) Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team
On Fri, Apr 01, 2016 at 01:27:02PM +0200, Andrea Bolognani wrote:
On Fri, 2016-04-01 at 13:04 +0200, Martin Kletzander wrote:
On Fri, Apr 01, 2016 at 11:35:09AM +0200, Andrea Bolognani wrote:
According to MDN[1], the 'margin-left' CSS property cannot be ... left ... applied to the '::first-line' pseudo-element, so this rule will never have any effect and can be safely removed. [1] https://developer.mozilla.org/en/docs/Web/CSS/::first-line --- docs/generic.css | 4 ---- 1 file changed, 4 deletions(-) diff --git a/docs/generic.css b/docs/generic.css index 4f98b26..208e31e 100644 --- a/docs/generic.css +++ b/docs/generic.css @@ -7,10 +7,6 @@ body { background: #ffffff; } -p:first-line { - margin-right: 1em; ... right ... ???
It makes even less sense that way, doesn't it? I get wanting to have a bigger left margin for the first line, but why would you even want to have a bigger *right* margin?
In any case, the MDN page clearly states that only a small subset of CSS properties can be used for the ::first-line pseudo-element, and the margin-* are not among those.
So consider the commit message fixed: the change itself is still desiderable :)
Well, ACK with that, then ;) And I believe it's safe as this is docs/ change
Cheers.
-- Andrea Bolognani Software Engineer - Virtualization Team
On Fri, 2016-04-01 at 14:46 +0200, Martin Kletzander wrote:
So consider the commit message fixed: the change itself is still desiderable :) Well, ACK with that, then ;) And I believe it's safe as this is docs/ change
Pushed, thanks! -- Andrea Bolognani Software Engineer - Virtualization Team
participants (2)
-
Andrea Bolognani -
Martin Kletzander