[Libvir] Build error without Xen
Hi, The recent changes to src/xml.c breaks the build without xen: $ ./autogen.sh \ --prefix=/usr \ --mandir=\${prefix}/share/man \ --infodir=\${prefix}/share/info \ --sysconfdir=/etc \ --localstatedir=/var \ --without-xen $ make ... gcc -g -O2 -o .libs/virsh -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wextra -Wshadow -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Winline -Wredundant-decls -Wno-sign-compare -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fasynchronous-unwind-tables virsh-virsh.o virsh-console.o -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wextra -Wshadow -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Winline -Wredundant-decls -Wno-sign-compare -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fasynchronous-unwind-tables ./.libs/libvirt.so -lcurses -lreadline ./.libs/libvirt.so: undefined reference to `xenNbCpus' collect2: ld returned 1 exit status make[2]: *** [virsh] Error 1 make[2]: Leaving directory `/usr/local/src/libvirt/libvirt/src' -jim
Jim Paris wrote:
Hi,
The recent changes to src/xml.c breaks the build without xen:
$ ./autogen.sh \ --prefix=/usr \ --mandir=\${prefix}/share/man \ --infodir=\${prefix}/share/info \ --sysconfdir=/etc \ --localstatedir=/var \ --without-xen $ make ... gcc -g -O2 -o .libs/virsh -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wextra -Wshadow -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Winline -Wredundant-decls -Wno-sign-compare -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fasynchronous-unwind-tables virsh-virsh.o virsh-console.o -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wextra -Wshadow -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Winline -Wredundant-decls -Wno-sign-compare -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fasynchronous-unwind-tables ./.libs/libvirt.so -lcurses -lreadline ./.libs/libvirt.so: undefined reference to `xenNbCpus' collect2: ld returned 1 exit status make[2]: *** [virsh] Error 1 make[2]: Leaving directory `/usr/local/src/libvirt/libvirt/src'
That's be a problem with the recent NUMA changes, I think ... Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903
On Fri, Oct 26, 2007 at 09:31:48AM +0100, Richard W.M. Jones wrote:
Jim Paris wrote:
Hi,
The recent changes to src/xml.c breaks the build without xen:
$ ./autogen.sh \ --prefix=/usr \ --mandir=\${prefix}/share/man \ --infodir=\${prefix}/share/info \ --sysconfdir=/etc \ --localstatedir=/var \ --without-xen $ make ... gcc -g -O2 -o .libs/virsh -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wextra -Wshadow -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Winline -Wredundant-decls -Wno-sign-compare -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fasynchronous-unwind-tables virsh-virsh.o virsh-console.o -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wextra -Wshadow -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Winline -Wredundant-decls -Wno-sign-compare -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fasynchronous-unwind-tables ./.libs/libvirt.so -lcurses -lreadline ./.libs/libvirt.so: undefined reference to `xenNbCpus' collect2: ld returned 1 exit status make[2]: *** [virsh] Error 1 make[2]: Leaving directory `/usr/local/src/libvirt/libvirt/src'
That's be a problem with the recent NUMA changes, I think ...
Oops, okay, I will look ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
On Fri, Oct 26, 2007 at 09:12:16AM -0400, Daniel Veillard wrote:
On Fri, Oct 26, 2007 at 09:31:48AM +0100, Richard W.M. Jones wrote:
Jim Paris wrote:
Hi,
The recent changes to src/xml.c breaks the build without xen: [...] ./.libs/libvirt.so: undefined reference to `xenNbCpus' [...]
That's be a problem with the recent NUMA changes, I think ...
Oops, okay, I will look !
okay, fixed in CVS, though I find a bit weird to compile virDomainParseXMLDesc when building without Xen, I think this is to be able to run the regression tests even if it's not configured in. It's probably my fault actually as I remember arguing for that a long time ago :-) thanks for raising the issue ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
participants (3)
-
Daniel Veillard -
Jim Paris -
Richard W.M. Jones