[libvirt] [PATCH] rpc:fix sasl session relocking intead of unlocking it
When to make use of any SASL authentication for TCP sockets by setting auth_tls = "sasl" in libvirtd.conf on server side,The client will hange because of the sasl session relocking other than dropping it in virNetSASLSessionExtKeySize() --- src/rpc/virnetsaslcontext.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/rpc/virnetsaslcontext.c b/src/rpc/virnetsaslcontext.c index ef36e2c..d4e7bf2 100644 --- a/src/rpc/virnetsaslcontext.c +++ b/src/rpc/virnetsaslcontext.c @@ -298,7 +298,7 @@ int virNetSASLSessionExtKeySize(virNetSASLSessionPtr sasl, ret = 0; cleanup: - virMutexLock(&sasl->lock); + virMutexUnlock(&sasl->lock); return ret; } -- 1.7.1
On Wed, Aug 03, 2011 at 09:27:23PM +0800, Guannan Ren wrote:
When to make use of any SASL authentication for TCP sockets by setting auth_tls = "sasl" in libvirtd.conf on server side,The client will hange because of the sasl session relocking other than dropping it in virNetSASLSessionExtKeySize() --- src/rpc/virnetsaslcontext.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/rpc/virnetsaslcontext.c b/src/rpc/virnetsaslcontext.c index ef36e2c..d4e7bf2 100644 --- a/src/rpc/virnetsaslcontext.c +++ b/src/rpc/virnetsaslcontext.c @@ -298,7 +298,7 @@ int virNetSASLSessionExtKeySize(virNetSASLSessionPtr sasl, ret = 0;
cleanup: - virMutexLock(&sasl->lock); + virMutexUnlock(&sasl->lock); return ret; }
Ouch, I don't see how that can be anything but a typo, good catch ! ACK, I pushed with just a bit of cleanup on the commit message Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
participants (2)
-
Daniel Veillard -
Guannan Ren