[libvirt] [PATCH 2/2] Add a detailed message when tap device add fails

Added a more detailed error message when adding a tap devices fails and the kernel is missing tun support. Signed-off-by: Doug Goldstein <cardoe@gentoo.org> --- src/uml/uml_conf.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/uml/uml_conf.c b/src/uml/uml_conf.c index 025169f..4b1df84 100644 --- a/src/uml/uml_conf.c +++ b/src/uml/uml_conf.c @@ -146,6 +146,11 @@ umlConnectTapDevice(virDomainNetDefPtr net, umlReportError(VIR_ERR_INTERNAL_ERROR, _("Failed to add tap interface to bridge. " "%s is not a bridge device"), bridge); + } else if (err == ENOENT) { + virReportSystemError(err, "%s", + _("Failed to add tap interface to bridge. Your kernel " + "is missing the 'tun' module or CONFIG_TUN or you need " + "to add the /dev/net/tun device node.")); } else if (template_ifname) { virReportSystemError(err, _("Failed to add tap interface to bridge '%s'"), -- 1.7.2

On 08/10/2010 03:43 PM, Doug Goldstein wrote:
Added a more detailed error message when adding a tap devices fails and the kernel is missing tun support.
Signed-off-by: Doug Goldstein <cardoe@gentoo.org>
Both of these are already in git. http://libvirt.org/git/?p=libvirt.git;a=commit;h=0890a70a1 http://libvirt.org/git/?p=libvirt.git;a=commit;h=bcc8b58be Any reason for the resend? -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org

On 08/10/2010 04:14 PM, Eric Blake wrote:
On 08/10/2010 03:43 PM, Doug Goldstein wrote:
Added a more detailed error message when adding a tap devices fails and the kernel is missing tun support.
Signed-off-by: Doug Goldstein <cardoe@gentoo.org>
Both of these are already in git. http://libvirt.org/git/?p=libvirt.git;a=commit;h=0890a70a1 http://libvirt.org/git/?p=libvirt.git;a=commit;h=bcc8b58be
Any reason for the resend?
Whoops - my bad. This touches uml, rather than qemu (other than the difference in files, the patches look the same). ACK, applying them, and apologies for mis-reading them ;) -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org

On Tue, Aug 10, 2010 at 5:38 PM, Eric Blake <eblake@redhat.com> wrote:
On 08/10/2010 04:14 PM, Eric Blake wrote:
On 08/10/2010 03:43 PM, Doug Goldstein wrote:
Added a more detailed error message when adding a tap devices fails and the kernel is missing tun support.
Signed-off-by: Doug Goldstein <cardoe@gentoo.org>
Both of these are already in git. http://libvirt.org/git/?p=libvirt.git;a=commit;h=0890a70a1 http://libvirt.org/git/?p=libvirt.git;a=commit;h=bcc8b58be
Any reason for the resend?
Whoops - my bad. This touches uml, rather than qemu (other than the difference in files, the patches look the same).
ACK, applying them, and apologies for mis-reading them ;)
Yeah I should have clarified sorry. Thanks for applying them. -- Doug Goldstein
participants (2)
-
Doug Goldstein
-
Eric Blake