[libvirt] [PATCH] spec: Require augeas for sanlock
Even though we BuildRequire augeas in some cases, we need to require it even after if we build with sanlock. virt-sanlock-cleanup use it. --- libvirt.spec.in | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 648b50f..4d69c77 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -354,6 +354,8 @@ BuildRequires: libpciaccess-devel >= 0.10.9 BuildRequires: yajl-devel %endif %if %{with_sanlock} +#for virt-sanlock-cleanup +Requires: augeas BuildRequires: sanlock-devel %endif %if %{with_libpcap} -- 1.7.3.4
On 09/15/2011 08:57 AM, Michal Privoznik wrote:
Even though we BuildRequire augeas in some cases, we need to require it even after if we build with sanlock. virt-sanlock-cleanup use it. --- libvirt.spec.in | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 648b50f..4d69c77 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -354,6 +354,8 @@ BuildRequires: libpciaccess-devel>= 0.10.9 BuildRequires: yajl-devel %endif %if %{with_sanlock} +#for virt-sanlock-cleanup +Requires: augeas
The added line is right, but not in the right place. We've split the file so that the section on Requires is different than the section on BuildRequires. Can you float this line into the right place (it might mean duplicating the %if %{with_sanlock} conditional)? -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Even though we BuildRequire augeas in some cases, we need to require it even after if we build with sanlock. virt-sanlock-cleanup use it. --- libvirt.spec.in | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 648b50f..19f91d7 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -519,6 +519,8 @@ the virtualization capabilities of recent versions of Linux (and other OSes). Summary: Sanlock lock manager plugin for QEMU driver Group: Development/Libraries Requires: sanlock +#for virt-sanlock-cleanup require augeas +Requires: augeas Requires: %{name} = %{version}-%{release} %description lock-sanlock -- 1.7.3.4
On 09/15/2011 09:10 AM, Michal Privoznik wrote:
Even though we BuildRequire augeas in some cases, we need to require it even after if we build with sanlock. virt-sanlock-cleanup use it. --- libvirt.spec.in | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 648b50f..19f91d7 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -519,6 +519,8 @@ the virtualization capabilities of recent versions of Linux (and other OSes). Summary: Sanlock lock manager plugin for QEMU driver Group: Development/Libraries Requires: sanlock +#for virt-sanlock-cleanup require augeas +Requires: augeas Requires: %{name} = %{version}-%{release}
ACK. This makes the dependency limited to just the libvirt-lock-sanlock package. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On 15.09.2011 17:17, Eric Blake wrote:
On 09/15/2011 09:10 AM, Michal Privoznik wrote:
Even though we BuildRequire augeas in some cases, we need to require it even after if we build with sanlock. virt-sanlock-cleanup use it. --- libvirt.spec.in | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 648b50f..19f91d7 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -519,6 +519,8 @@ the virtualization capabilities of recent versions of Linux (and other OSes). Summary: Sanlock lock manager plugin for QEMU driver Group: Development/Libraries Requires: sanlock +#for virt-sanlock-cleanup require augeas +Requires: augeas Requires: %{name} = %{version}-%{release}
ACK. This makes the dependency limited to just the libvirt-lock-sanlock package.
Thanks, pushed.
At 09/15/2011 11:10 PM, Michal Privoznik Write:
Even though we BuildRequire augeas in some cases, we need to require it even after if we build with sanlock. virt-sanlock-cleanup use it. --- libvirt.spec.in | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 648b50f..19f91d7 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -519,6 +519,8 @@ the virtualization capabilities of recent versions of Linux (and other OSes). Summary: Sanlock lock manager plugin for QEMU driver Group: Development/Libraries Requires: sanlock +#for virt-sanlock-cleanup require augeas +Requires: augeas
On RHEL6.1GA, there is no package named augeas. It only has augeas-libs. On F15, it also only has augeas-libs. What is augeas? Thanks Wen Congyang
Requires: %{name} = %{version}-%{release}
%description lock-sanlock
On 09/18/2011 07:02 PM, Wen Congyang wrote:
At 09/15/2011 11:10 PM, Michal Privoznik Write:
Even though we BuildRequire augeas in some cases, we need to require it even after if we build with sanlock. virt-sanlock-cleanup use it. --- libvirt.spec.in | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 648b50f..19f91d7 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -519,6 +519,8 @@ the virtualization capabilities of recent versions of Linux (and other OSes). Summary: Sanlock lock manager plugin for QEMU driver Group: Development/Libraries Requires: sanlock +#for virt-sanlock-cleanup require augeas +Requires: augeas
On RHEL6.1GA, there is no package named augeas. It only has augeas-libs. On F15, it also only has augeas-libs.
What is augeas?
Augeas is the package that provides the standalone executable 'augtool' (this is the command line access to the augeas-libs library). It is built from the same sources as augeas-libs, though. I agree that it is not part of the stock RHEL 6.1GA repo, so you should probably raise a Red Hat bugzilla about getting it exposed now that libvirt wants to use it. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On 09/19/2011 10:22 AM, Eric Blake wrote:
On RHEL6.1GA, there is no package named augeas. It only has augeas-libs. On F15, it also only has augeas-libs.
What is augeas?
Augeas is the package that provides the standalone executable 'augtool' (this is the command line access to the augeas-libs library). It is built from the same sources as augeas-libs, though. I agree that it is not part of the stock RHEL 6.1GA repo, so you should probably raise a Red Hat bugzilla about getting it exposed now that libvirt wants to use it.
I went ahead and did this: https://bugzilla.redhat.com/show_bug.cgi?id=739627 -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (3)
-
Eric Blake -
Michal Privoznik -
Wen Congyang