From: Michal Privoznik <mprivozn@redhat.com> The 'reconnectBlockjobs' member of the _qemuDomainObjPrivate struct is basically unused after v8.7.0-rc1~110. It's not even formatted into the status XML, just parsed. This makes needless noise. Just drop the member. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/qemu/qemu_domain.c | 7 ------- src/qemu/qemu_domain.h | 3 --- 2 files changed, 10 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 60a4bcc64c..375e0e441a 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -1907,7 +1907,6 @@ qemuDomainObjPrivateDataClear(qemuDomainObjPrivate *priv) priv->rememberOwner = false; - priv->reconnectBlockjobs = VIR_TRISTATE_BOOL_ABSENT; priv->allowReboot = VIR_TRISTATE_BOOL_ABSENT; g_clear_pointer(&priv->migrationCaps, virBitmapFree); @@ -3211,14 +3210,8 @@ qemuDomainObjPrivateXMLParseBlockjobs(virDomainObj *vm, { g_autofree xmlNodePtr *nodes = NULL; ssize_t nnodes = 0; - g_autofree char *active = NULL; - int tmp; size_t i; - if ((active = virXPathString("string(./blockjobs/@active)", ctxt)) && - (tmp = virTristateBoolTypeFromString(active)) > 0) - priv->reconnectBlockjobs = tmp; - if ((nnodes = virXPathNodeSet("./blockjobs/blockjob", ctxt, &nodes)) < 0) return -1; diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 5ccd3b2dbb..f4945f598a 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -195,9 +195,6 @@ struct _qemuDomainObjPrivate { /* If true virtlogd is used as stdio handler for character devices. */ bool chardevStdioLogd; - /* Tracks blockjob state for vm. Valid only while reconnecting to qemu. */ - virTristateBool reconnectBlockjobs; - /* Migration capabilities. Rechecked on reconnect, not to be saved in * private XML. */ virBitmap *migrationCaps; -- 2.51.0