[libvirt] update from gnulib
I've just checked in a big batch of changes from gnulib. Each of those changes has been reviewed by at least two people (see bug-gnulib@gnu.org), and most of them address problems also reported on that list, or e.g., on bug-coreutils, bug-m4, etc. However, I suspect some of them have not yet been exercised on RHEL4/5 systems, so test builds there may be interesting.
From e6440820773161436812ccad7eba6d555a8186dd Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering@redhat.com> Date: Thu, 7 Aug 2008 10:28:22 +0200 Subject: [PATCH] update from gnulib
* build-aux/mktempd (rand_bytes, mktempd): * build-aux/useless-if-before-free (FILE): * build-aux/vc-list-files: * gnulib/lib/.cvsignore: * gnulib/lib/Makefile.am: * gnulib/lib/poll.c (poll): * gnulib/lib/stdbool.in.h (_GL_STDBOOL_H, true): * gnulib/lib/stdio-impl.h (fp_, fp_ub): * gnulib/lib/stdio.in.h (vasprintf, obstack_printf) (obstack_vprintf): * gnulib/lib/vasnprintf.c (_GNU_SOURCE, sprintf, IF_LINT, exp) (remainder, scale10_round_decimal_long_double) (scale10_round_decimal_double, pad_ourselves): * gnulib/m4/gnulib-cache.m4: * gnulib/m4/gnulib-common.m4 (gl_MODULE_INDICATOR): * gnulib/m4/gnulib-tool.m4 (gl_LOCAL_DIR, gl_M4_BASE, gl_PO_BASE) (gl_DOC_BASE, gl_TESTS_BASE, gl_WITH_TESTS, gl_LIB, gl_LGPL) (gl_MAKEFILE_NAME, gl_MACRO_PREFIX, gl_PO_DOMAIN, gl_VC_FILES): * gnulib/m4/lock.m4 (gl_LOCK_EARLY_BODY, gl_PREREQ_LOCK) (gl_DISABLE_THREADS): * gnulib/m4/onceonly.m4: * gnulib/m4/posix-shell.m4 (gl_POSIX_SHELL): * gnulib/m4/stdio_h.m4 (gl_STDIO_H_DEFAULTS): * gnulib/tests/test-getaddrinfo.c (ENABLE_DEBUGGING, dbgprintf) (simple): * gnulib/tests/test-stdint.c (UINTMAX_MAX, or): * gnulib/tests/test-vc-list-files-cvs.sh (compare): * gnulib/tests/test-vc-list-files-git.sh (compare): --- build-aux/mktempd | 6 +++- build-aux/useless-if-before-free | 32 +++++++++++++++--------- build-aux/vc-list-files | 5 ++- gnulib/lib/.cvsignore | 12 ++++---- gnulib/lib/Makefile.am | 15 +++++++++++- gnulib/lib/poll.c | 34 ++++++++++++++++++------- gnulib/lib/stdbool.in.h | 6 ++-- gnulib/lib/stdio-impl.h | 4 +- gnulib/lib/stdio.in.h | 20 +++++++++++++++ gnulib/lib/vasnprintf.c | 25 +++++++++++++++---- gnulib/m4/gnulib-cache.m4 | 21 ++++++++++++++- gnulib/m4/gnulib-common.m4 | 9 ++++++- gnulib/m4/gnulib-tool.m4 | 28 ++++++++++++++++++++- gnulib/m4/lock.m4 | 37 +++++++++++++++++++++------- gnulib/m4/onceonly.m4 | 15 +++++++---- gnulib/m4/posix-shell.m4 | 7 +++-- gnulib/m4/stdio_h.m4 | 6 ++++- gnulib/tests/test-getaddrinfo.c | 41 +++++++++++++++++++------------ gnulib/tests/test-stdint.c | 6 ++++- gnulib/tests/test-vc-list-files-cvs.sh | 3 +- gnulib/tests/test-vc-list-files-git.sh | 3 +- 21 files changed, 249 insertions(+), 86 deletions(-)
On Thu, Aug 07, 2008 at 11:46:29AM +0200, Jim Meyering wrote:
I've just checked in a big batch of changes from gnulib. Each of those changes has been reviewed by at least two people (see bug-gnulib@gnu.org), and most of them address problems also reported on that list, or e.g., on bug-coreutils, bug-m4, etc.
However, I suspect some of them have not yet been exercised on RHEL4/5 systems, so test builds there may be interesting.
Hum, on RHEL5 configure/make passes, make tests fails one of the 18 tests: /u/veillard/libvirt/tests/conftest: No such file or directory FAIL: test_conf.sh test:~/libvirt -> file /u/veillard/libvirt/tests/conftest /u/veillard/libvirt/tests/conftest: ELF 64-bit LSB executable, AMD x86-64, version 1 (SYSV), for GNU/Linux 2.6.9, dynamically linked (uses shared libs), for GNU/Linux 2.6.9, not stripped test:~/libvirt -> ldd /u/veillard/libvirt/tests/conftest doesn't show any unresolved lib I didn't found yet what's going on for RHEL4 i need the followig patch for it to compile (the function changed but the signature of the dummy didn't get fixed) Index: src/bridge.c =================================================================== RCS file: /data/cvs/libvir/src/bridge.c,v retrieving revision 1.16 diff -u -p -r1.16 bridge.c --- src/bridge.c 11 Jul 2008 19:34:11 -0000 1.16 +++ src/bridge.c 7 Aug 2008 09:54:05 -0000 @@ -156,9 +156,7 @@ brAddBridge(brControl *ctl, } #else int brAddBridge (brControl *ctl ATTRIBUTE_UNUSED, - const char *nameOrFmt ATTRIBUTE_UNUSED, - char *name ATTRIBUTE_UNUSED, - int maxlen ATTRIBUTE_UNUSED) + char **name ATTRIBUTE_UNUSED) { return EINVAL; } I then get 7 of 17 tests failed and 1 not run 1) virsh list (default) ... FAILED 2) virsh list (custom) ... OK 3) virsh nodeinfo (default) ... FAILED 4) virsh nodeinfo (custom) ... OK in virshtest the same ./test_conf.sh: line 21: /u/veillard/libvirt/tests /u/veillard/libvirt/tests/conftest: No such file or directory FAIL: test_conf.sh as on RHEL5 and then a bunch of errors on the individual tests, but I guess it's because there is no hypervisor running or available on that box :-) basically gnulib update seems to not be a problem ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
Daniel Veillard <veillard@redhat.com> wrote: ...
However, I suspect some of them have not yet been exercised on RHEL4/5 systems, so test builds there may be interesting.
on RHEL5 configure/make passes, make tests fails one of the 18 tests: ... for RHEL4 i need the followig patch for it to compile (the function changed but the signature of the dummy didn't get fixed)
Looks fine. ACK.
Index: src/bridge.c =================================================================== RCS file: /data/cvs/libvir/src/bridge.c,v retrieving revision 1.16 diff -u -p -r1.16 bridge.c --- src/bridge.c 11 Jul 2008 19:34:11 -0000 1.16 +++ src/bridge.c 7 Aug 2008 09:54:05 -0000 @@ -156,9 +156,7 @@ brAddBridge(brControl *ctl, } #else int brAddBridge (brControl *ctl ATTRIBUTE_UNUSED, - const char *nameOrFmt ATTRIBUTE_UNUSED, - char *name ATTRIBUTE_UNUSED, - int maxlen ATTRIBUTE_UNUSED) + char **name ATTRIBUTE_UNUSED) ... basically gnulib update seems to not be a problem !
Good to hear. Thanks for the quick checks!
participants (2)
-
Daniel Veillard -
Jim Meyering