RE: [Libvir] Problems installing libvir
Daniel, This was more of a hurried hack just changing all curses to ncurses :-) I know it's no excuse, but I was in a hurry to start linking to libvirt. I will work on a cleaner change to configure.in and forward it to you later today? Thanks Raj PS. Didn't Jim Fehlig mention that he has already fixed this? -----Original Message----- From: Daniel Veillard [mailto:veillard@redhat.com] Sent: Tuesday, April 25, 2006 4:06 AM To: Subrahmanian, Raj Cc: libvir-list@redhat.com Subject: Re: [Libvir] Problems installing libvir On Mon, Apr 24, 2006 at 09:25:45PM -0400, Subrahmanian, Raj wrote:
ncurses vs. curses ? Ohh, and I was looking right at it! Sorry folks. I hacked the configure file to look for ncurses and sure enough it worked.
Can you send the diff you made to configure.in so we can fix configure to work with both libraries ? Daniel -- Daniel Veillard | Red Hat http://redhat.com/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
On Tue, Apr 25, 2006 at 08:13:48AM -0400, Subrahmanian, Raj wrote:
Daniel, This was more of a hurried hack just changing all curses to ncurses :-) I know it's no excuse, but I was in a hurry to start linking to libvirt. I will work on a cleaner change to configure.in and forward it to you later today?
okay, make sure to work from the CVS version, it helps :-)
PS. Didn't Jim Fehlig mention that he has already fixed this?
Hum, I don't remember that, maybe I missed a patch, right now there is only AC_CHECK_LIB(curses, initscr, ... in the CVS configure.in so that's not fixed here, Daniel -- Daniel Veillard | Red Hat http://redhat.com/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
On Tue, Apr 25, 2006 at 09:08:02AM -0400, Daniel Veillard wrote:
PS. Didn't Jim Fehlig mention that he has already fixed this?
I don't remember too.
Hum, I don't remember that, maybe I missed a patch, right now there is only AC_CHECK_LIB(curses, initscr, ... in the CVS configure.in so that's not fixed here,
Possible fix (not tested): AC_CHECK_LIB(curses, initscr, [VIRSH_LIBS="$VIRSH_LIBS -lcurses"], [ AC_CHECK_LIB(ncurses, initscr, [VIRSH_LIBS="$VIRSH_LIBS -lncurses"], [AC_MSG_ERROR([curses/ncurses library not found])], [$VIRSH_LIBS]) ], [$VIRSH_LIBS]) ... nice explosion of [([])].. .. :-) Karel -- Karel Zak <kzak@redhat.com>
participants (3)
-
Daniel Veillard -
Karel Zak -
Subrahmanian, Raj