[libvirt] [libvirt-perl PATCH] Add support for VIR_SECRET_USAGE_TYPE_PASSPHRASE
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- This fixes a build for me with upstream libvirt. Virt.xs | 1 + lib/Sys/Virt/Secret.pm | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/Virt.xs b/Virt.xs index cf4e5bc5337c..4c9f86b972f3 100644 --- a/Virt.xs +++ b/Virt.xs @@ -8534,6 +8534,7 @@ BOOT: REGISTER_CONSTANT(VIR_SECRET_USAGE_TYPE_VOLUME, USAGE_TYPE_VOLUME); REGISTER_CONSTANT(VIR_SECRET_USAGE_TYPE_CEPH, USAGE_TYPE_CEPH); REGISTER_CONSTANT(VIR_SECRET_USAGE_TYPE_ISCSI, USAGE_TYPE_ISCSI); + REGISTER_CONSTANT(VIR_SECRET_USAGE_TYPE_PASSPHRASE, USAGE_TYPE_PASSPHRASE); REGISTER_CONSTANT(VIR_CONNECT_LIST_SECRETS_EPHEMERAL, LIST_EPHEMERAL); diff --git a/lib/Sys/Virt/Secret.pm b/lib/Sys/Virt/Secret.pm index b8711909e7ba..beab68badef3 100644 --- a/lib/Sys/Virt/Secret.pm +++ b/lib/Sys/Virt/Secret.pm @@ -149,6 +149,11 @@ The constant for secrets which are to be used for authenticating to iSCSI storage volumes. The usage ID for secrets will refer to the server name. +=item Sys::Virt::Secret::USAGE_TYPE_PASSPHRASE + +The constant for general purpose secret to be used by various libvirt +objects to provide a single passphrase. + =back =head2 LIST FILTERING -- 2.9.0
On Mon, Jul 04, 2016 at 04:37:27PM +0200, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- This fixes a build for me with upstream libvirt.
NACK, per my reply to John's original patch, I think this should not have been added to libvirt API in the first place. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On Mon, Jul 04, 2016 at 03:41:16PM +0100, Daniel P. Berrange wrote:
On Mon, Jul 04, 2016 at 04:37:27PM +0200, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- This fixes a build for me with upstream libvirt.
NACK, per my reply to John's original patch, I think this should not have been added to libvirt API in the first place.
I missed that. Looking at it now I was wondering why we have special purpose, dedicated secrets to that they are used safely and now we have general-purpose secret. OK, good to know, I haven't thought of that, I just wanted to fix the test. Thanks for the info.
Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Mon, Jul 04, 2016 at 04:49:56PM +0200, Martin Kletzander wrote:
On Mon, Jul 04, 2016 at 03:41:16PM +0100, Daniel P. Berrange wrote:
On Mon, Jul 04, 2016 at 04:37:27PM +0200, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- This fixes a build for me with upstream libvirt.
NACK, per my reply to John's original patch, I think this should not have been added to libvirt API in the first place.
I missed that. Looking at it now I was wondering why we have special purpose, dedicated secrets to that they are used safely and now we have general-purpose secret. OK, good to know, I haven't thought of that, I just wanted to fix the test. Thanks for the info.
Oh, I guess John is not around today, due to 4th July, so we'll have to wait for him to return to resolve this. ACK to pushing your patch now to fix the build, and we'll just revert it later if we revert the main libvirt.so patch. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On Mon, Jul 04, 2016 at 04:22:32PM +0100, Daniel P. Berrange wrote:
On Mon, Jul 04, 2016 at 04:49:56PM +0200, Martin Kletzander wrote:
On Mon, Jul 04, 2016 at 03:41:16PM +0100, Daniel P. Berrange wrote:
On Mon, Jul 04, 2016 at 04:37:27PM +0200, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- This fixes a build for me with upstream libvirt.
NACK, per my reply to John's original patch, I think this should not have been added to libvirt API in the first place.
I missed that. Looking at it now I was wondering why we have special purpose, dedicated secrets to that they are used safely and now we have general-purpose secret. OK, good to know, I haven't thought of that, I just wanted to fix the test. Thanks for the info.
Oh, I guess John is not around today, due to 4th July, so we'll have to wait for him to return to resolve this.
ACK to pushing your patch now to fix the build, and we'll just revert it later if we revert the main libvirt.so patch.
OK, pushed now, feel free to revert it when appropriate. Thanks.
Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
participants (2)
-
Daniel P. Berrange -
Martin Kletzander