[libvirt] c&p error in api doc

I think there's a c&p error: http://libvirt.org/html/libvirt-libvirt.html#virStoragePoolUndefine "Returns: a virStoragePoolPtr object, or NULL if creation failed" I assume it is "0 on success, -1 on failure" as the return is of type int. kr,t

On Tuesday 21 July 2009 18:23:16 Thomas Treutner wrote:
I think there's a c&p error:
http://libvirt.org/html/libvirt-libvirt.html#virStoragePoolUndefine
"Returns: a virStoragePoolPtr object, or NULL if creation failed"
I assume it is "0 on success, -1 on failure" as the return is of type int.
And a small follow-up: In libvirt-java, StoragePool::Undefine() has return type void. So I don't know what's really going on there ;-) kr,t

On Tue, Jul 21, 2009 at 06:34:31PM +0200, Thomas Treutner wrote:
On Tuesday 21 July 2009 18:23:16 Thomas Treutner wrote:
I think there's a c&p error:
http://libvirt.org/html/libvirt-libvirt.html#virStoragePoolUndefine
"Returns: a virStoragePoolPtr object, or NULL if creation failed"
I assume it is "0 on success, -1 on failure" as the return is of type int.
And a small follow-up:
In libvirt-java, StoragePool::Undefine() has return type void. So I don't know what's really going on there ;-)
they are just forgetting the return value :-\ Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

On Wed, Jul 22, 2009 at 08:43:43AM +0200, Daniel Veillard wrote:
On Tue, Jul 21, 2009 at 06:34:31PM +0200, Thomas Treutner wrote:
On Tuesday 21 July 2009 18:23:16 Thomas Treutner wrote:
I think there's a c&p error:
http://libvirt.org/html/libvirt-libvirt.html#virStoragePoolUndefine
"Returns: a virStoragePoolPtr object, or NULL if creation failed"
I assume it is "0 on success, -1 on failure" as the return is of type int.
And a small follow-up:
In libvirt-java, StoragePool::Undefine() has return type void. So I don't know what's really going on there ;-)
they are just forgetting the return value :-\
Sure java doesn't need return values for errors - it'll just throw an exception. So all libvirt methods would be 'void' unless they were returning actual data Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

On Tue, Jul 21, 2009 at 06:23:16PM +0200, Thomas Treutner wrote:
I think there's a c&p error:
http://libvirt.org/html/libvirt-libvirt.html#virStoragePoolUndefine
"Returns: a virStoragePoolPtr object, or NULL if creation failed"
I assume it is "0 on success, -1 on failure" as the return is of type int.
Okay, fixed in git, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
participants (3)
-
Daniel P. Berrange
-
Daniel Veillard
-
Thomas Treutner