[libvirt] [PATCH] build: drop useless dirent.h includes

* .gnulib: Update to latest, for improved syntax-check. * src/lxc/lxc_container.c (includes): Drop unused include. * src/network/bridge_driver.c: Likewise. * src/node_device/node_device_linux_sysfs.c: Likewise. * src/openvz/openvz_driver.c: Likewise. * src/qemu/qemu_conf.c: Likewise. * src/storage/storage_backend_iscsi.c: Likewise. * src/storage/storage_backend_mpath.c: Likewise. * src/uml/uml_conf.c: Likewise. * src/uml/uml_driver.c: Likewise. --- I'm not sure whether to include this in 0.9.7. On the one hand, this is pretty trivial; on the other hand, I hate making more .gnulib updates than necessary after release candidates have been posted, in case an unintended regression sneaks in from a half-baked gnulib change. But looking at the 22 patches, I'm not seeing anything likely to impact libvirt besides the new syntax check rule. * .gnulib 0031e4f...e56e96f (22):
maint.mk: silence new syntax check Doc about floating-point and math API. stdalign tests: Skip the test when compiled by Sun C. ansi-c++-opt: Complete the 2011-06-05 change. * doc/posix-headers/stdalign.texi (stdalign.h): Mention Sun review ID. copysignl: Fix result for zero argument on HP-UX 11 with HP C. update from texinfo ldexp, ldexpf, ldexpl: Enhance tests. math tests: Cosmetics. fma*: Simplify test. Tests for module 'fmal'. New module 'fmal'. Tests for module 'fmaf'. New module 'fmaf'. Tests for module 'fma'. New module 'fma'. Extend gl_MATHFUNC. New modules 'at-internal', 'openat-h', split off from module 'openat'. maint.mk: also prohibit inclusion of dirent.h without use ldexpl tests: Avoid test failure on MSVC 9. New modules 'at-internal', 'openat-h', split off from module 'openat'. openat: Include <stdbool.h>.
.gnulib | 2 +- src/lxc/lxc_container.c | 1 - src/network/bridge_driver.c | 1 - src/node_device/node_device_linux_sysfs.c | 3 +-- src/openvz/openvz_driver.c | 1 - src/qemu/qemu_conf.c | 1 - src/storage/storage_backend_iscsi.c | 1 - src/storage/storage_backend_mpath.c | 3 +-- src/uml/uml_conf.c | 1 - src/uml/uml_driver.c | 1 - 10 files changed, 3 insertions(+), 12 deletions(-) diff --git a/.gnulib b/.gnulib index 0031e4f..e56e96f 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit 0031e4f6353cc7077a9d0dad0c793bd6e3dc7aaa +Subproject commit e56e96fe20f72586e9ec5c528b9a9a06daa2ecc6 diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index c4e5f28..c2484a7 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -35,7 +35,6 @@ #include <sys/stat.h> #include <unistd.h> #include <mntent.h> -#include <dirent.h> /* Yes, we want linux private one, for _syscall2() macro */ #include <linux/unistd.h> diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 445c3cb..e897b32 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -25,7 +25,6 @@ #include <sys/types.h> #include <sys/poll.h> -#include <dirent.h> #include <limits.h> #include <string.h> #include <stdio.h> diff --git a/src/node_device/node_device_linux_sysfs.c b/src/node_device/node_device_linux_sysfs.c index 844231a..d352800 100644 --- a/src/node_device/node_device_linux_sysfs.c +++ b/src/node_device/node_device_linux_sysfs.c @@ -2,7 +2,7 @@ * node_device_hal_linuc.c: Linux specific code to gather device data * not available through HAL. * - * Copyright (C) 2009-2010 Red Hat, Inc. + * Copyright (C) 2009-2011 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -32,7 +32,6 @@ #include "memory.h" #include "logging.h" #include "virfile.h" -#include <dirent.h> #define VIR_FROM_THIS VIR_FROM_NODEDEV diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index 69ff444..4eed8ad 100644 --- a/src/openvz/openvz_driver.c +++ b/src/openvz/openvz_driver.c @@ -30,7 +30,6 @@ #include <sys/types.h> #include <sys/poll.h> -#include <dirent.h> #include <limits.h> #include <string.h> #include <stdio.h> diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index d1bf075..0cf921f 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -23,7 +23,6 @@ #include <config.h> -#include <dirent.h> #include <string.h> #include <limits.h> #include <sys/types.h> diff --git a/src/storage/storage_backend_iscsi.c b/src/storage/storage_backend_iscsi.c index 99e69c9..354f99b 100644 --- a/src/storage/storage_backend_iscsi.c +++ b/src/storage/storage_backend_iscsi.c @@ -32,7 +32,6 @@ #include <regex.h> #include <fcntl.h> #include <unistd.h> -#include <dirent.h> #include <sys/stat.h> #include "virterror_internal.h" diff --git a/src/storage/storage_backend_mpath.c b/src/storage/storage_backend_mpath.c index 4f3add3..f09ce9b 100644 --- a/src/storage/storage_backend_mpath.c +++ b/src/storage/storage_backend_mpath.c @@ -1,7 +1,7 @@ /* * storage_backend_mpath.c: storage backend for multipath handling * - * Copyright (C) 2009-2010 Red Hat, Inc. + * Copyright (C) 2009-2011 Red Hat, Inc. * Copyright (C) 2009-2008 Dave Allan * * This library is free software; you can redistribute it and/or @@ -25,7 +25,6 @@ #include <unistd.h> #include <stdio.h> -#include <dirent.h> #include <fcntl.h> #include <libdevmapper.h> diff --git a/src/uml/uml_conf.c b/src/uml/uml_conf.c index f2bdd74..e06eb90 100644 --- a/src/uml/uml_conf.c +++ b/src/uml/uml_conf.c @@ -23,7 +23,6 @@ #include <config.h> -#include <dirent.h> #include <string.h> #include <limits.h> #include <sys/types.h> diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c index 772e1c6..35b73b6 100644 --- a/src/uml/uml_driver.c +++ b/src/uml/uml_driver.c @@ -25,7 +25,6 @@ #include <sys/types.h> #include <sys/poll.h> -#include <dirent.h> #include <limits.h> #include <string.h> #include <stdio.h> -- 1.7.4.4

On 11/07/2011 10:50 AM, Eric Blake wrote:
* .gnulib: Update to latest, for improved syntax-check. * src/lxc/lxc_container.c (includes): Drop unused include. * src/network/bridge_driver.c: Likewise. * src/node_device/node_device_linux_sysfs.c: Likewise. * src/openvz/openvz_driver.c: Likewise. * src/qemu/qemu_conf.c: Likewise. * src/storage/storage_backend_iscsi.c: Likewise. * src/storage/storage_backend_mpath.c: Likewise. * src/uml/uml_conf.c: Likewise. * src/uml/uml_driver.c: Likewise. ---
I'm not sure whether to include this in 0.9.7. On the one hand, this is pretty trivial; on the other hand, I hate making more .gnulib updates than necessary after release candidates have been posted, in case an unintended regression sneaks in from a half-baked gnulib change. But looking at the 22 patches, I'm not seeing anything likely to impact libvirt besides the new syntax check rule.
Now that 0.9.7 is out the door, and no one else commented, I'll go ahead and push this under the trivial rule.
.gnulib | 2 +- src/lxc/lxc_container.c | 1 - src/network/bridge_driver.c | 1 - src/node_device/node_device_linux_sysfs.c | 3 +-- src/openvz/openvz_driver.c | 1 - src/qemu/qemu_conf.c | 1 - src/storage/storage_backend_iscsi.c | 1 - src/storage/storage_backend_mpath.c | 3 +-- src/uml/uml_conf.c | 1 - src/uml/uml_driver.c | 1 - 10 files changed, 3 insertions(+), 12 deletions(-)
-- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (1)
-
Eric Blake