[PATCH v2 0/2] qemu: support some missing params on live attaching chardev
Specifying chardev logfile and file backend append param is ignored yet. Diff from v1: - use existing virJSONValueObjectAdd instead of introducing virJSONValueObjectAppendBooleanTristate. Nikolay Shirokovskiy (2): qemu: support append param on live attaching file chardev qemu: support logfile on live attaching chardev src/qemu/qemu_monitor_json.c | 11 +++++++++++ 1 file changed, 11 insertions(+) -- 1.8.3.1
Currently it is simply ignored. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com> --- src/qemu/qemu_monitor_json.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 47ee1ff..ff03a5a 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -7497,6 +7497,10 @@ qemuMonitorJSONAttachCharDevCommand(const char *chrID, backend_type = "file"; if (virJSONValueObjectAppendString(data, "out", chr->data.file.path) < 0) goto cleanup; + if (virJSONValueObjectAdd(data, + "T:append", chr->data.file.append, + NULL) < 0) + goto cleanup; break; case VIR_DOMAIN_CHR_TYPE_DEV: -- 1.8.3.1
On 12/2/20 9:25 AM, Nikolay Shirokovskiy wrote:
Currently it is simply ignored.
Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com> ---
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
src/qemu/qemu_monitor_json.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 47ee1ff..ff03a5a 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -7497,6 +7497,10 @@ qemuMonitorJSONAttachCharDevCommand(const char *chrID, backend_type = "file"; if (virJSONValueObjectAppendString(data, "out", chr->data.file.path) < 0) goto cleanup; + if (virJSONValueObjectAdd(data, + "T:append", chr->data.file.append, + NULL) < 0) + goto cleanup; break;
case VIR_DOMAIN_CHR_TYPE_DEV:
Currently it is simply ignored. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com> --- src/qemu/qemu_monitor_json.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index ff03a5a..0745717 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -7611,6 +7611,13 @@ qemuMonitorJSONAttachCharDevCommand(const char *chrID, goto cleanup; } + if (chr->logfile && + virJSONValueObjectAdd(data, + "s:logfile", chr->logfile, + "T:logappend", chr->logappend, + NULL) < 0) + goto cleanup; + if (virJSONValueObjectAppendString(backend, "type", backend_type) < 0 || virJSONValueObjectAppend(backend, "data", data) < 0) goto cleanup; -- 1.8.3.1
On 12/2/20 9:25 AM, Nikolay Shirokovskiy wrote:
Currently it is simply ignored.
Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com> ---
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
src/qemu/qemu_monitor_json.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index ff03a5a..0745717 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -7611,6 +7611,13 @@ qemuMonitorJSONAttachCharDevCommand(const char *chrID, goto cleanup; }
+ if (chr->logfile && + virJSONValueObjectAdd(data, + "s:logfile", chr->logfile, + "T:logappend", chr->logappend, + NULL) < 0) + goto cleanup; + if (virJSONValueObjectAppendString(backend, "type", backend_type) < 0 || virJSONValueObjectAppend(backend, "data", data) < 0) goto cleanup;
participants (2)
-
Daniel Henrique Barboza -
Nikolay Shirokovskiy