When the password change failed we updated the graphic definition anyways, which is not desired. --- src/qemu/qemu_hotplug.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 1251d6b..a8a904c 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1517,6 +1517,8 @@ qemuDomainChangeGraphics(struct qemud_driver *driver, VIR_DOMAIN_GRAPHICS_TYPE_VNC, &dev->data.vnc.auth, driver->vncPassword); + if (ret < 0) + return ret; /* Steal the new dev's char * reference */ VIR_FREE(olddev->data.vnc.auth.passwd); @@ -1576,6 +1578,9 @@ qemuDomainChangeGraphics(struct qemud_driver *driver, &dev->data.spice.auth, driver->spicePassword); + if (ret < 0) + return ret; + /* Steal the new dev's char * reference */ VIR_FREE(olddev->data.spice.auth.passwd); olddev->data.spice.auth.passwd = dev->data.spice.auth.passwd; -- 1.7.12