[libvirt] [PATCH] qemu: Properly detect crash of a rebooted domain
When a domain is rebooted using libvirt API, we use fake reboot consisting of shutting down and resetting the domain. Thus we see a SHUTDOWN event and set gotShutdown flag. But we never reset it back and if the domain crashes after it was rebooted this way, we consider it was a normal shutdown and not a crash. --- src/qemu/qemu_process.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index ca4f21f..1332e04 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -405,6 +405,7 @@ qemuProcessFakeReboot(void *opaque) "%s", _("resume operation failed")); goto endjob; } + priv->gotShutdown = false; event = virDomainEventNewFromObj(vm, VIR_DOMAIN_EVENT_RESUMED, VIR_DOMAIN_EVENT_RESUMED_UNPAUSED); -- 1.7.6.1
On 09/13/2011 10:53 AM, Jiri Denemark wrote:
When a domain is rebooted using libvirt API, we use fake reboot consisting of shutting down and resetting the domain. Thus we see a SHUTDOWN event and set gotShutdown flag. But we never reset it back and if the domain crashes after it was rebooted this way, we consider it was a normal shutdown and not a crash. --- src/qemu/qemu_process.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
ACK. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On Tue, Sep 13, 2011 at 10:59:50 -0600, Eric Blake wrote:
On 09/13/2011 10:53 AM, Jiri Denemark wrote:
When a domain is rebooted using libvirt API, we use fake reboot consisting of shutting down and resetting the domain. Thus we see a SHUTDOWN event and set gotShutdown flag. But we never reset it back and if the domain crashes after it was rebooted this way, we consider it was a normal shutdown and not a crash. --- src/qemu/qemu_process.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
ACK.
Thanks, pushed. Jirka
participants (2)
-
Eric Blake -
Jiri Denemark