On Mon, Jul 27, 2009 at 01:15:16PM +0200, Matthias Bolte wrote:

Adds a no_verify query parameter to stop libcurl from verifying the server certificate for the https transport.

Idea from Tom Hughes.

ACK, this matches the same no_verify parameter supported for the generic 'remote' driver, which is nice!

diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index aa73e46..8f1ebfb 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -70,8 +70,21 @@ typedef struct _esxPrivate {

/* - * URI format: esx://[<user>@]<server>[?transport={http|https}][&vcenter=<vcenter>] + * URI format: esx://[<user>@]<server>[?transport={http|https}][&vcenter=<vcenter>][&no_verify={0|1}] * esx:///phantom + * + * If no transport parameter is specified https is used. + * + * The vcenter parameter is only necessary for migration, because the vCenter + * server is in charge to initiate a migration between two ESX hosts. + * + * If the no_verify parameter is set to 1, this disables libcurl client checks + * of the server's certificate. + * + * The esx:///phantom URI may be used for tasks that don't require an actual + * connection to the hypervisor like domxml-{from,to}-native: + * + * virsh -c esx:///phantom domxml-from-native vmware-vmx dummy.vmx */

Docs in the code are nice. Docs on the website are even nicer ! If you have time, could you send a patch adding a page for the VMWare driver to the website. The website is generated from the .html.in files under the docs/ directory. Simply create a docs/drvesx.html.in file and list it under 'Documentation -> Drivers -> VMWare ESX' in the docs/sitemap.html.in file. Even if it it merely gives a couple of example URIs for ESX that would be a great start. Anymore info that might be useful to users is a bonus... Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|