[PATCH] vbox: fix memory leak in vboxStartMachine()
vboxStartMachine() allocates sdlDisplay via g_strdup() and doesn't free it. Add VIR_FREE. Fixes: 3f4f0ef47d (vbox: Fix starting domains) Signed-off-by: Elizaveta Tereshkina <teryoshkina.ea@gmail.com> --- src/vbox/vbox_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 65ae9cc651..a47183927d 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -2252,6 +2252,7 @@ vboxStartMachine(virDomainPtr dom, int maxDomID, IMachine *machine) VBOX_UTF8_TO_UTF16(displayutf8, &env); VIR_FREE(displayutf8); VIR_FREE(guiDisplay); + VIR_FREE(sdlDisplay); VBOX_UTF8_TO_UTF16(sessType, &sessionType); } else if (vrdpPresent) { -- 2.39.2
On a Wednesday in 2026, Elizaveta Tereshkina wrote:
vboxStartMachine() allocates sdlDisplay via g_strdup() and doesn't free it. Add VIR_FREE.
Fixes: 3f4f0ef47d (vbox: Fix starting domains) Signed-off-by: Elizaveta Tereshkina <teryoshkina.ea@gmail.com> --- src/vbox/vbox_common.c | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Ján Tomko <jtomko@redhat.com> This function seems like a good candidate for a conversion to use g_autofree. Jano
diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 65ae9cc651..a47183927d 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -2252,6 +2252,7 @@ vboxStartMachine(virDomainPtr dom, int maxDomID, IMachine *machine) VBOX_UTF8_TO_UTF16(displayutf8, &env); VIR_FREE(displayutf8); VIR_FREE(guiDisplay); + VIR_FREE(sdlDisplay);
VBOX_UTF8_TO_UTF16(sessType, &sessionType); } else if (vrdpPresent) { -- 2.39.2
participants (2)
-
Elizaveta Tereshkina -
Ján Tomko