[libvirt] [PATCH] docs: fix typos in libvirt.h.in
From: Chen Hanxiao <chenhanxiao@cn.fujitsu.com> s/caused/cause Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com> --- include/libvirt/libvirt.h.in | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index 146a59b..934d425 100644 --- a/include/libvirt/libvirt.h.in +++ b/include/libvirt/libvirt.h.in @@ -3461,7 +3461,7 @@ typedef enum { /** * virDomainEventDefinedDetailType: * - * Details on the caused of the 'defined' lifecycle event + * Details on the cause of the 'defined' lifecycle event */ typedef enum { VIR_DOMAIN_EVENT_DEFINED_ADDED = 0, /* Newly created config file */ @@ -3475,7 +3475,7 @@ typedef enum { /** * virDomainEventUndefinedDetailType: * - * Details on the caused of the 'undefined' lifecycle event + * Details on the cause of the 'undefined' lifecycle event */ typedef enum { VIR_DOMAIN_EVENT_UNDEFINED_REMOVED = 0, /* Deleted the config file */ @@ -3488,7 +3488,7 @@ typedef enum { /** * virDomainEventStartedDetailType: * - * Details on the caused of the 'started' lifecycle event + * Details on the cause of the 'started' lifecycle event */ typedef enum { VIR_DOMAIN_EVENT_STARTED_BOOTED = 0, /* Normal startup from boot */ @@ -3505,7 +3505,7 @@ typedef enum { /** * virDomainEventSuspendedDetailType: * - * Details on the caused of the 'suspended' lifecycle event + * Details on the cause of the 'suspended' lifecycle event */ typedef enum { VIR_DOMAIN_EVENT_SUSPENDED_PAUSED = 0, /* Normal suspend due to admin pause */ @@ -3524,7 +3524,7 @@ typedef enum { /** * virDomainEventResumedDetailType: * - * Details on the caused of the 'resumed' lifecycle event + * Details on the cause of the 'resumed' lifecycle event */ typedef enum { VIR_DOMAIN_EVENT_RESUMED_UNPAUSED = 0, /* Normal resume due to admin unpause */ @@ -3539,7 +3539,7 @@ typedef enum { /** * virDomainEventStoppedDetailType: * - * Details on the caused of the 'stopped' lifecycle event + * Details on the cause of the 'stopped' lifecycle event */ typedef enum { VIR_DOMAIN_EVENT_STOPPED_SHUTDOWN = 0, /* Normal shutdown */ -- 1.8.2.1
On Thu, Nov 28, 2013 at 5:31 PM, Chen Hanxiao <chenhanxiao@cn.fujitsu.com> wrote:
From: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
s/caused/cause
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com> --- include/libvirt/libvirt.h.in | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index 146a59b..934d425 100644 --- a/include/libvirt/libvirt.h.in +++ b/include/libvirt/libvirt.h.in @@ -3461,7 +3461,7 @@ typedef enum { /** * virDomainEventDefinedDetailType: * - * Details on the caused of the 'defined' lifecycle event + * Details on the cause of the 'defined' lifecycle event */ 1.8.2.1
I am no English expert, but would like to ask, if a particular event can take place due to multiple reasons, shouldn't it be : "Details on the causes of the 'defined' lifecycle event" I think the original author made a typo by typing 'd' instead of 's' (very close on keyboard), i.e., s/caused/causes -- Nehal J Wani
-----Original Message----- From: Nehal J Wani [mailto:nehaljw.kkd1@gmail.com] Sent: Thursday, November 28, 2013 10:03 PM To: Chen Hanxiao Cc: libvir-list Subject: Re: [libvirt] [PATCH] docs: fix typos in libvirt.h.in
On Thu, Nov 28, 2013 at 5:31 PM, Chen Hanxiao <chenhanxiao@cn.fujitsu.com> wrote:
From: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
s/caused/cause
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com> --- include/libvirt/libvirt.h.in | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index 146a59b..934d425 100644 --- a/include/libvirt/libvirt.h.in +++ b/include/libvirt/libvirt.h.in @@ -3461,7 +3461,7 @@ typedef enum { /** * virDomainEventDefinedDetailType: * - * Details on the caused of the 'defined' lifecycle event + * Details on the cause of the 'defined' lifecycle event */ 1.8.2.1
I am no English expert, but would like to ask, if a particular event can take place due to multiple reasons, shouldn't it be : "Details on the causes of the 'defined' lifecycle event" I think the original author made a typo by typing 'd' instead of 's' (very close on keyboard), i.e., s/caused/causes
Sound reasonable. Thanks for your comments.
-- Nehal J Wani
On 11/28/2013 07:03 AM, Nehal J Wani wrote:
On Thu, Nov 28, 2013 at 5:31 PM, Chen Hanxiao <chenhanxiao@cn.fujitsu.com> wrote:
From: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
/** * virDomainEventDefinedDetailType: * - * Details on the caused of the 'defined' lifecycle event + * Details on the cause of the 'defined' lifecycle event */ 1.8.2.1
I am no English expert, but would like to ask, if a particular event can take place due to multiple reasons, shouldn't it be : "Details on the causes of the 'defined' lifecycle event" I think the original author made a typo by typing 'd' instead of 's' (very close on keyboard), i.e., s/caused/causes
Causes would make sense if you could have a plurality of causes triggering a single event. But we don't. Each event has exactly one cause. The patch is correct as-is, so I'll apply it soon. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (3)
-
Chen Hanxiao -
Eric Blake -
Nehal J Wani