[libvirt] [PATCH] host-validate: Fix suggestion for missing cpu cgroup
If the cpu cgroup is not found when validating an host for LXC support, virt-host-validate will suggest to enable the CONFIG_CGROUP_SCHED kconfig option. The appropriate option is really CONFIG_CGROUP_CPU. The QEMU checks already get that right, so no changes needed. --- tools/virt-host-validate-lxc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virt-host-validate-lxc.c b/tools/virt-host-validate-lxc.c index 89a6388..2b906cc 100644 --- a/tools/virt-host-validate-lxc.c +++ b/tools/virt-host-validate-lxc.c @@ -70,7 +70,7 @@ int virHostValidateLXC(void) if (virHostValidateCGroupController("LXC", "cpu", VIR_HOST_VALIDATE_FAIL, - "CGROUP_SCHED") < 0) + "CGROUP_CPU") < 0) ret = -1; if (virHostValidateCGroupController("LXC", "cpuacct", -- 2.5.5
On Tue, Mar 29, 2016 at 18:45:02 +0200, Andrea Bolognani wrote:
If the cpu cgroup is not found when validating an host for LXC support, virt-host-validate will suggest to enable the CONFIG_CGROUP_SCHED kconfig option.
The appropriate option is really CONFIG_CGROUP_CPU. The QEMU checks already get that right, so no changes needed. --- tools/virt-host-validate-lxc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK, safe for freeze. Peter
On Wed, 2016-03-30 at 08:37 +0200, Peter Krempa wrote:
On Tue, Mar 29, 2016 at 18:45:02 +0200, Andrea Bolognani wrote:
If the cpu cgroup is not found when validating an host for LXC support, virt-host-validate will suggest to enable the CONFIG_CGROUP_SCHED kconfig option.
The appropriate option is really CONFIG_CGROUP_CPU. The QEMU checks already get that right, so no changes needed. --- tools/virt-host-validate-lxc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK, safe for freeze.
Pushed, thanks :) -- Andrea Bolognani Software Engineer - Virtualization Team
participants (2)
-
Andrea Bolognani -
Peter Krempa