[libvirt PATCH 0/1] Fix the failing integration CI stage
Avocado has changed something in their internals between v98.0 and v99.0 which caused our TCK test suite to start failing in GitLab. The problem could not be identified easily because GitLab doesn't run 'after_script' when a job timeout is reached [1]. Avocado issue created here [2]. Here's a successful pipeline with the patch applied [3]. [1] https://gitlab.com/gitlab-org/gitlab/-/issues/15603 [2] https://github.com/avocado-framework/avocado/issues/5521 [3] https://gitlab.com/eskultety/libvirt/-/pipelines/695512878 Erik Skultety (1): ci: integration: Lock the Avocado version to 98.0 for now ci/integration-template.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.38.1
Avocado 99.0 causes the TCK test suite to fail with the nwfilter tests (which is another Bash framework underneath). Until the culprit is identified and fixed in Avocado, let's lock the version to 98.0 which worked with the test suite just fine. Signed-off-by: Erik Skultety <eskultet@redhat.com> --- ci/integration-template.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ci/integration-template.yml b/ci/integration-template.yml index f01de7845d..61cd034009 100644 --- a/ci/integration-template.yml +++ b/ci/integration-template.yml @@ -26,7 +26,9 @@ .install-deps: &install-deps - sudo dnf install -y libvirt-rpms/* libvirt-perl-rpms/* libvirt-python-rpms/* - - sudo pip3 install --prefix=/usr avocado-framework + + # Avocado >98.0 fails with the nwfilter TCK tests, so stick with 98.0 for now + - sudo pip3 install --prefix=/usr avocado-framework==98.0 .enable-core-dumps: &enable-core-dumps -- 2.38.1
On 11/16/22 09:39, Erik Skultety wrote:
Avocado 99.0 causes the TCK test suite to fail with the nwfilter tests (which is another Bash framework underneath). Until the culprit is identified and fixed in Avocado, let's lock the version to 98.0 which worked with the test suite just fine.
Signed-off-by: Erik Skultety <eskultet@redhat.com> --- ci/integration-template.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ci/integration-template.yml b/ci/integration-template.yml index f01de7845d..61cd034009 100644 --- a/ci/integration-template.yml +++ b/ci/integration-template.yml @@ -26,7 +26,9 @@
.install-deps: &install-deps - sudo dnf install -y libvirt-rpms/* libvirt-perl-rpms/* libvirt-python-rpms/* - - sudo pip3 install --prefix=/usr avocado-framework + + # Avocado >98.0 fails with the nwfilter TCK tests, so stick with 98.0 for now + - sudo pip3 install --prefix=/usr avocado-framework==98.0
.enable-core-dumps: &enable-core-dumps
Reviewed-by: Michal Privoznik <mprivozn@redhat.com> and we should make a mental note to set the version free again when avocado's fixed. Michal
participants (2)
-
Erik Skultety -
Michal Prívozník