[libvirt] [PATCH] Allow libvirtd to RPC to external libvirtd.
Allow the daemon itself to make RPCs to an external libvirtd, but only if the URI is fully specified. While this isn't used at the moment, it will be for the tunnelled migration support in the future. Signed-off-by: Chris Lalancette <clalance@redhat.com> --- src/remote_internal.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/remote_internal.c b/src/remote_internal.c index ad0cbf0..ff4fb6c 100644 --- a/src/remote_internal.c +++ b/src/remote_internal.c @@ -997,7 +997,7 @@ remoteOpen (virConnectPtr conn, int ret, rflags = 0; const char *autostart = getenv("LIBVIRT_AUTOSTART"); - if (inside_daemon) + if (inside_daemon && (!conn->uri || (conn->uri && !conn->uri->server))) return VIR_DRV_OPEN_DECLINED; if (!(priv = remoteAllocPrivateData(conn))) -- 1.6.0.6
On Fri, Jul 31, 2009 at 03:19:51PM +0200, Chris Lalancette wrote:
Allow the daemon itself to make RPCs to an external libvirtd, but only if the URI is fully specified. While this isn't used at the moment, it will be for the tunnelled migration support in the future.
ACK but let's postpone after 0.7.0, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
Daniel Veillard wrote:
On Fri, Jul 31, 2009 at 03:19:51PM +0200, Chris Lalancette wrote:
Allow the daemon itself to make RPCs to an external libvirtd, but only if the URI is fully specified. While this isn't used at the moment, it will be for the tunnelled migration support in the future.
ACK but let's postpone after 0.7.0,
Yep, agreed, totally fine with me. -- Chris Lalancette
On Wed, Aug 05, 2009 at 11:22:12AM +0200, Daniel Veillard wrote:
On Fri, Jul 31, 2009 at 03:19:51PM +0200, Chris Lalancette wrote:
Allow the daemon itself to make RPCs to an external libvirtd, but only if the URI is fully specified. While this isn't used at the moment, it will be for the tunnelled migration support in the future.
ACK but let's postpone after 0.7.0,
NB this should not be applied until the potential UNIX socket path length checks have been fixed. Also the migration code using this capability needs to very verify virGetHostname on its current connection is different to virGetHostname after connecting, otherwise it will likely deadlock the daemon Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
participants (3)
-
Chris Lalancette -
Daniel P. Berrange -
Daniel Veillard