[libvirt] [PATCH] qemu: fix uninitialized variable warning in doPeer2PeerMigrate
False positive, but it breaks the build with gcc-4.6.3. qemu/qemu_migration.c:2931:37: error: 'offline' may be used uninitialized in this function [-Werror=uninitialized] qemu/qemu_migration.c:2887:10: note: 'offline' was declared here --- src/qemu/qemu_migration.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 0ca7dd4..8796eb6 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2884,7 +2884,7 @@ static int doPeer2PeerMigrate(virQEMUDriverPtr driver, virConnectPtr dconn = NULL; bool p2p; virErrorPtr orig_err = NULL; - bool offline; + bool offline = false; VIR_DEBUG("driver=%p, sconn=%p, vm=%p, xmlin=%s, dconnuri=%s, " "uri=%s, flags=%lx, dname=%s, resource=%lu", -- 1.7.8.6
On 12/11/12 12:50, Ján Tomko wrote:
False positive, but it breaks the build with gcc-4.6.3.
qemu/qemu_migration.c:2931:37: error: 'offline' may be used uninitialized in this function [-Werror=uninitialized] qemu/qemu_migration.c:2887:10: note: 'offline' was declared here --- src/qemu/qemu_migration.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
ACK Peter
On 12/11/12 13:29, Peter Krempa wrote:
On 12/11/12 12:50, Ján Tomko wrote:
False positive, but it breaks the build with gcc-4.6.3.
qemu/qemu_migration.c:2931:37: error: 'offline' may be used uninitialized in this function [-Werror=uninitialized] qemu/qemu_migration.c:2887:10: note: 'offline' was declared here --- src/qemu/qemu_migration.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
ACK
and pushed.
Peter
participants (2)
-
Ján Tomko -
Peter Krempa