[libvirt] Entering freeze for libvirt-1.1.3
I'm a day late from suggested schedule, but I have now tagged rc1 in git and pushed the tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ My initial testing didn't revealed anything bad, but wider testing is obviously needed, i have heard of problem on FreeBSD by Jason, hopefully we can collect and fix those in time. I will probably make rc2 during the w.e. and depending on news push on Tuesday next week or a bit later the final 1.1.3 thanks for testing and reports ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/
On 26/09/2013, at 6:30 AM, Daniel Veillard wrote: <snip>
I will probably make rc2 during the w.e. and depending on news push on Tuesday next week or a bit later the final 1.1.3
Compiles ok on MacOS 10.7. virsh starts ok too. One weirdness noted from inside virsh (not connected to a hypervisor): virsh # version error: failed to connect to the hypervisor error: no valid connection error: Failed to find user record for uid '32766' Not sure what the "32766" comes from, since that's not the id of my user: uid=501(jc) gid=20(staff) groups=20(staff) Doesn't seem like a blocker though. + Justin -- Open Source and Standards @ Red Hat twitter.com/realjustinclift
On 26.09.2013 10:59, Justin Clift wrote:
On 26/09/2013, at 6:30 AM, Daniel Veillard wrote: <snip>
I will probably make rc2 during the w.e. and depending on news push on Tuesday next week or a bit later the final 1.1.3
Compiles ok on MacOS 10.7. virsh starts ok too.
One weirdness noted from inside virsh (not connected to a hypervisor):
virsh # version error: failed to connect to the hypervisor error: no valid connection error: Failed to find user record for uid '32766'
Not sure what the "32766" comes from, since that's not the id of my user:
Isn't it a PID of the virsh process? I think we fail to get identity for the virsh process and mislead users by wrong error message.
uid=501(jc) gid=20(staff) groups=20(staff)
Doesn't seem like a blocker though.
I'd say it is a blocker. Michal
On 26/09/2013, at 10:05 AM, Michal Privoznik wrote:
On 26.09.2013 10:59, Justin Clift wrote:
On 26/09/2013, at 6:30 AM, Daniel Veillard wrote: <snip>
I will probably make rc2 during the w.e. and depending on news push on Tuesday next week or a bit later the final 1.1.3
Compiles ok on MacOS 10.7. virsh starts ok too.
One weirdness noted from inside virsh (not connected to a hypervisor):
virsh # version error: failed to connect to the hypervisor error: no valid connection error: Failed to find user record for uid '32766'
Not sure what the "32766" comes from, since that's not the id of my user:
Isn't it a PID of the virsh process? I think we fail to get identity for the virsh process and mislead users by wrong error message.
Doesn't seem like it. Just started virsh again, but the pid of that process doesn't match the # given this time (which did change though). Terminal window 1: virsh # version error: failed to connect to the hypervisor error: no valid connection error: Failed to find user record for uid '32706' Terminal window 2: (virsh still open in #1) $ ps -ef|grep -i virsh 501 35262 35252 0 10:38am ttys000 0:00.03 virsh $ ps -ef|grep -i 32706 $ Not seeing anything in the "327xx" range, and new pid's are (atm) in the "353xx" range. Not sure where it's picking up the "uid" value from, and haven't really tried tracing it. I wonder if it's just an OSX thing, or if maybe *BSD is showing something similar... + Justin -- Open Source and Standards @ Red Hat twitter.com/realjustinclift
On Thu, Sep 26, 2013 at 10:43:34AM +0100, Justin Clift wrote:
On 26/09/2013, at 10:05 AM, Michal Privoznik wrote:
On 26.09.2013 10:59, Justin Clift wrote:
On 26/09/2013, at 6:30 AM, Daniel Veillard wrote: <snip>
I will probably make rc2 during the w.e. and depending on news push on Tuesday next week or a bit later the final 1.1.3
Compiles ok on MacOS 10.7. virsh starts ok too.
One weirdness noted from inside virsh (not connected to a hypervisor):
virsh # version error: failed to connect to the hypervisor error: no valid connection error: Failed to find user record for uid '32766'
Not sure what the "32766" comes from, since that's not the id of my user:
Isn't it a PID of the virsh process? I think we fail to get identity for the virsh process and mislead users by wrong error message.
Doesn't seem like it. Just started virsh again, but the pid of that process doesn't match the # given this time (which did change though).
Terminal window 1:
virsh # version error: failed to connect to the hypervisor error: no valid connection error: Failed to find user record for uid '32706'
Terminal window 2: (virsh still open in #1)
$ ps -ef|grep -i virsh 501 35262 35252 0 10:38am ttys000 0:00.03 virsh $ ps -ef|grep -i 32706 $
Not seeing anything in the "327xx" range, and new pid's are (atm) in the "353xx" range.
Not sure where it's picking up the "uid" value from, and haven't really tried tracing it. I wonder if it's just an OSX thing, or if maybe *BSD is showing something similar...
Attach to it with gdb and put a breakpoint on virGetUserEnt and see what arg is passed up for the 'uid' parameter. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On Thu, Sep 26, 2013 at 4:43 AM, Justin Clift <jclift@redhat.com> wrote:
On 26/09/2013, at 10:05 AM, Michal Privoznik wrote:
On 26.09.2013 10:59, Justin Clift wrote:
On 26/09/2013, at 6:30 AM, Daniel Veillard wrote: <snip>
I will probably make rc2 during the w.e. and depending on news push on Tuesday next week or a bit later the final 1.1.3
Compiles ok on MacOS 10.7. virsh starts ok too.
One weirdness noted from inside virsh (not connected to a hypervisor):
virsh # version error: failed to connect to the hypervisor error: no valid connection error: Failed to find user record for uid '32766'
Not sure what the "32766" comes from, since that's not the id of my user:
Isn't it a PID of the virsh process? I think we fail to get identity for the virsh process and mislead users by wrong error message.
Doesn't seem like it. Just started virsh again, but the pid of that process doesn't match the # given this time (which did change though).
Terminal window 1:
virsh # version error: failed to connect to the hypervisor error: no valid connection error: Failed to find user record for uid '32706'
Terminal window 2: (virsh still open in #1)
$ ps -ef|grep -i virsh 501 35262 35252 0 10:38am ttys000 0:00.03 virsh $ ps -ef|grep -i 32706 $
Not seeing anything in the "327xx" range, and new pid's are (atm) in the "353xx" range.
Not sure where it's picking up the "uid" value from, and haven't really tried tracing it. I wonder if it's just an OSX thing, or if maybe *BSD is showing something similar...
+ Justin
-- Open Source and Standards @ Red Hat
twitter.com/realjustinclift
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
The PID will change everytime virsh starts a new session libvirtd, which happens everytime we go through a timeout. -- Doug Goldstein
On Thu, Sep 26, 2013 at 3:59 AM, Justin Clift <jclift@redhat.com> wrote:
On 26/09/2013, at 6:30 AM, Daniel Veillard wrote: <snip>
I will probably make rc2 during the w.e. and depending on news push on Tuesday next week or a bit later the final 1.1.3
Compiles ok on MacOS 10.7. virsh starts ok too.
One weirdness noted from inside virsh (not connected to a hypervisor):
virsh # version error: failed to connect to the hypervisor error: no valid connection error: Failed to find user record for uid '32766'
Not sure what the "32766" comes from, since that's not the id of my user:
uid=501(jc) gid=20(staff) groups=20(staff)
Doesn't seem like a blocker though.
+ Justin
-- Open Source and Standards @ Red Hat
twitter.com/realjustinclift
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Justin, This was the error I brought up on the ML with the 1.1.2 release. I still haven't had a chance to get to the bottom of it. The issue stems from the fact that we're getting back bad socket credentials. I've submitted a patch to catch this case that needs review: https://www.redhat.com/archives/libvir-list/2013-September/msg01403.html -- Doug Goldstein
On Thu, Sep 26, 2013 at 1:13 PM, Doug Goldstein <cardoe@gentoo.org> wrote:
On Thu, Sep 26, 2013 at 3:59 AM, Justin Clift <jclift@redhat.com> wrote:
On 26/09/2013, at 6:30 AM, Daniel Veillard wrote: <snip>
I will probably make rc2 during the w.e. and depending on news push on Tuesday next week or a bit later the final 1.1.3
Compiles ok on MacOS 10.7. virsh starts ok too.
One weirdness noted from inside virsh (not connected to a hypervisor):
virsh # version error: failed to connect to the hypervisor error: no valid connection error: Failed to find user record for uid '32766'
Not sure what the "32766" comes from, since that's not the id of my user:
uid=501(jc) gid=20(staff) groups=20(staff)
Doesn't seem like a blocker though.
+ Justin
-- Open Source and Standards @ Red Hat
twitter.com/realjustinclift
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Justin,
This was the error I brought up on the ML with the 1.1.2 release. I still haven't had a chance to get to the bottom of it. The issue stems from the fact that we're getting back bad socket credentials. I've submitted a patch to catch this case that needs review:
https://www.redhat.com/archives/libvir-list/2013-September/msg01403.html
-- Doug Goldstein
I should also note that my patchset doesn't fix the whole issue. We are always failing when we look up the socket info on Mac OS X (we have for a really really really long time). But at least we detect the error instead of silently ignoring it and trying to look up bad data. -- Doug Goldstein
On 26/09/2013, at 7:16 PM, Doug Goldstein wrote:
On Thu, Sep 26, 2013 at 1:13 PM, Doug Goldstein <cardoe@gentoo.org> wrote: <snip>
This was the error I brought up on the ML with the 1.1.2 release. I still haven't had a chance to get to the bottom of it. The issue stems from the fact that we're getting back bad socket credentials. I've submitted a patch to catch this case that needs review:
I should also note that my patchset doesn't fix the whole issue. We are always failing when we look up the socket info on Mac OS X (we have for a really really really long time). But at least we detect the error instead of silently ignoring it and trying to look up bad data.
Cool. At least it's a "known thing" then, not a new one. I'll leave this to you guys to sort out, as it's been *ages* since my head has been in libvirt development mode. ;) + Justin -- Open Source and Standards @ Red Hat twitter.com/realjustinclift
On Thu, Sep 26, 2013 at 01:30:53PM +0800, Daniel Veillard wrote:
I'm a day late from suggested schedule, but I have now tagged rc1 in git and pushed the tarball and rpms to the usual place: ftp://libvirt.org/libvirt/
My initial testing didn't revealed anything bad, but wider testing is obviously needed, i have heard of problem on FreeBSD by Jason, hopefully we can collect and fix those in time.
I will probably make rc2 during the w.e. and depending on news push on Tuesday next week or a bit later the final 1.1.3
thanks for testing and reports !
make check is failing since check-perms.pl is missing from the tarball, see followup patch. Cheers, -- Guido
so "make check" can work for the distributed tarballs too. --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 4375ef7..4057eda 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -533,7 +533,7 @@ check-aclperms: $(srcdir)/access/viraccessperm.h \ $(srcdir)/access/viraccessperm.c -EXTRA_DIST += check-driverimpls.pl check-aclrules.pl +EXTRA_DIST += check-driverimpls.pl check-aclrules.pl check-aclperms.pl check-local: check-protocol check-symfile check-symsorting \ check-drivername check-driverimpls check-aclrules \ -- 1.8.4.rc3
On Thu, Sep 26, 2013 at 01:39:26PM +0200, Guido Günther wrote:
so "make check" can work for the distributed tarballs too. --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Makefile.am b/src/Makefile.am index 4375ef7..4057eda 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -533,7 +533,7 @@ check-aclperms: $(srcdir)/access/viraccessperm.h \ $(srcdir)/access/viraccessperm.c
-EXTRA_DIST += check-driverimpls.pl check-aclrules.pl +EXTRA_DIST += check-driverimpls.pl check-aclrules.pl check-aclperms.pl
check-local: check-protocol check-symfile check-symsorting \ check-drivername check-driverimpls check-aclrules \ --
ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On Thu, Sep 26, 2013 at 12:42:19PM +0100, Daniel P. Berrange wrote:
On Thu, Sep 26, 2013 at 01:39:26PM +0200, Guido Günther wrote:
so "make check" can work for the distributed tarballs too. --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Makefile.am b/src/Makefile.am index 4375ef7..4057eda 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -533,7 +533,7 @@ check-aclperms: $(srcdir)/access/viraccessperm.h \ $(srcdir)/access/viraccessperm.c
-EXTRA_DIST += check-driverimpls.pl check-aclrules.pl +EXTRA_DIST += check-driverimpls.pl check-aclrules.pl check-aclperms.pl
check-local: check-protocol check-symfile check-symsorting \ check-drivername check-driverimpls check-aclrules \ --
ACK
Pushed. Thanks. -- Guido
Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On Thu, Sep 26, 2013 at 01:38:17PM +0200, Guido Günther wrote:
On Thu, Sep 26, 2013 at 01:30:53PM +0800, Daniel Veillard wrote:
I'm a day late from suggested schedule, but I have now tagged rc1 in git and pushed the tarball and rpms to the usual place: ftp://libvirt.org/libvirt/
My initial testing didn't revealed anything bad, but wider testing is obviously needed, i have heard of problem on FreeBSD by Jason, hopefully we can collect and fix those in time.
I will probably make rc2 during the w.e. and depending on news push on Tuesday next week or a bit later the final 1.1.3
thanks for testing and reports !
make check is failing since check-perms.pl is missing from the tarball, see followup patch. Cheers,
Weird make check is run from tarball when making the rpm, but i didn't looked closely on the rpmbuild Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/
On Thu, Sep 26, 2013 at 5:06 AM, Daniel Veillard <veillard@redhat.com>wrote:
On Thu, Sep 26, 2013 at 01:38:17PM +0200, Guido Günther wrote:
On Thu, Sep 26, 2013 at 01:30:53PM +0800, Daniel Veillard wrote:
I'm a day late from suggested schedule, but I have now tagged rc1 in git and pushed the tarball and rpms to the usual place: ftp://libvirt.org/libvirt/
My initial testing didn't revealed anything bad, but wider testing is obviously needed, i have heard of problem on FreeBSD by Jason, hopefully we can collect and fix those in time.
I will probably make rc2 during the w.e. and depending on news push on Tuesday next week or a bit later the final 1.1.3
thanks for testing and reports !
Builds clean here. No other checking per issues aforementioned in thread. http://redports.org/buildarchive/20130926070701-44410/ -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serve
On Thu, Sep 26, 2013 at 08:06:54PM +0800, Daniel Veillard wrote:
On Thu, Sep 26, 2013 at 01:38:17PM +0200, Guido Günther wrote:
On Thu, Sep 26, 2013 at 01:30:53PM +0800, Daniel Veillard wrote:
I'm a day late from suggested schedule, but I have now tagged rc1 in git and pushed the tarball and rpms to the usual place: ftp://libvirt.org/libvirt/
My initial testing didn't revealed anything bad, but wider testing is obviously needed, i have heard of problem on FreeBSD by Jason, hopefully we can collect and fix those in time.
I will probably make rc2 during the w.e. and depending on news push on Tuesday next week or a bit later the final 1.1.3
thanks for testing and reports !
make check is failing since check-perms.pl is missing from the tarball, see followup patch. Cheers,
Weird make check is run from tarball when making the rpm, but i didn't looked closely on the rpmbuild
Besides of that everything looks good on Debian's buildds: https://buildd.debian.org/status/package.php?p=libvirt&suite=experimental The powerpc failure is a problem on the buildd, not a libvirt one. Cheers, -- Guido
On 09/25/2013 11:30 PM, Daniel Veillard wrote:
I'm a day late from suggested schedule, but I have now tagged rc1 in git and pushed the tarball and rpms to the usual place: ftp://libvirt.org/libvirt/
My initial testing didn't revealed anything bad, but wider testing is obviously needed, i have heard of problem on FreeBSD by Jason, hopefully we can collect and fix those in time.
I will probably make rc2 during the w.e. and depending on news push on Tuesday next week or a bit later the final 1.1.3
thanks for testing and reports !
I'm investigating some failures on cygwin 1.7.25, built with './configure --without-vbox': CC libvirtd_conf_la-libvirtd-config.lo In file included from ../src/rpc/virnetmessage.h:24:0, from ../src/rpc/virnetserverprogram.h:27, from ../src/rpc/virnetserver.h:32, from libvirtd-config.c:31: ../src/rpc/virnetprotocol.h:9:21: fatal error: rpc/rpc.h: No such file or directory I suspect it is just a missing CFLAGS, since other Makefile.am manage to include the appropriate -I/usr/lib/tirpc just fine, as needed for that header. Also, the gnulib testsuite will fail at least test-dup2, but this is due to a bug in cygwin where I have posted upstream fixes for cygwin[1] and gnulib[2]. I'm unwilling to update this particular libvirt release to the newest gnulib just to work around the problem (the risk of breaking some other platform with a last-minute change to dup2 outweighs the benefit of solving the testsuite failure on cygwin for this release). [1] http://cygwin.com/ml/cygwin-developers/2013-q3/msg00010.html [2] https://lists.gnu.org/archive/html/bug-gnulib/2013-09/msg00072.html -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On 09/26/2013 02:51 PM, Eric Blake wrote:
I suspect it is just a missing CFLAGS, since other Makefile.am manage to include the appropriate -I/usr/lib/tirpc just fine, as needed for that header.
I've gotten mostly past that, except that 'make -C src check' is trying to build lxc_monitor_protocol, even though that file is only needed by a WITH_LXC build (unlike lxc_protocol which is needed by a WITH_REMOTE build). I'm trying to sort that out now. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On 09/26/2013 07:30 AM, Daniel Veillard wrote:
I'm a day late from suggested schedule, but I have now tagged rc1 in git and pushed the tarball and rpms to the usual place: ftp://libvirt.org/libvirt/
My initial testing didn't revealed anything bad, but wider testing is obviously needed, i have heard of problem on FreeBSD by Jason, hopefully we can collect and fix those in time.
I will probably make rc2 during the w.e. and depending on news push on Tuesday next week or a bit later the final 1.1.3
thanks for testing and reports !
Daniel
Sniff test on s390 showed no problems, except for a vpath build error. I've sent a trivial patch. -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294
As planned I tagged rc2 in git and pushed tarball and rpms to the usual place at: ftp://libvirt.org/libvirt/ seems to behave correctly on my limited testing, please give it a try too. i will try to push 1.1.3 final on Tuesday or Wednesday depending on time available and feedback. thanks ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/
On Sun, Sep 29, 2013 at 4:16 AM, Daniel Veillard <veillard@redhat.com>wrote:
As planned I tagged rc2 in git and pushed tarball and rpms to the usual place at: ftp://libvirt.org/libvirt/
seems to behave correctly on my limited testing, please give it a try too. i will try to push 1.1.3 final on Tuesday or Wednesday depending on time available and feedback.
thanks !
Daniel
Looks good here. https://redports.org/buildarchive/20130930215801-5110/ -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serve
On Sun, Sep 29, 2013 at 6:16 AM, Daniel Veillard <veillard@redhat.com> wrote:
As planned I tagged rc2 in git and pushed tarball and rpms to the usual place at: ftp://libvirt.org/libvirt/
seems to behave correctly on my limited testing, please give it a try too. i will try to push 1.1.3 final on Tuesday or Wednesday depending on time available and feedback.
thanks !
Daniel
-- Daniel Veillard | Open Source and Standards, Red Hat veillard@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
fwiw, tested this on Mac OS X. Simple virsh commands work fine and the only issues that remain are the ones discussed in the rc1 thread that we won't be fixing for 1.1.3 but I will try to have some patches for shortly. -- Doug Goldstein
participants (9)
-
Daniel P. Berrange -
Daniel Veillard -
Doug Goldstein -
Eric Blake -
Guido Günther -
Jason Helfman -
Justin Clift -
Michal Privoznik -
Viktor Mihajlovski