[libvirt] [PATCH] cgroup: Fix possible memory leak in virCgroupMakeGroup
* src/util/cgroup.c: free temporal path string before breaking loop --- src/util/cgroup.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/util/cgroup.c b/src/util/cgroup.c index b649c3c..b8b2eb5 100644 --- a/src/util/cgroup.c +++ b/src/util/cgroup.c @@ -472,8 +472,10 @@ static int virCgroupMakeGroup(virCgroupPtr parent, virCgroupPtr group, int creat (i == VIR_CGROUP_CONTROLLER_CPUSET || STREQ(group->controllers[i].mountPoint, group->controllers[VIR_CGROUP_CONTROLLER_CPUSET].mountPoint))) { rc = virCgroupCpuSetInherit(parent, group); - if (rc != 0) + if (rc != 0) { + VIR_FREE(path); break; + } } } -- 1.6.5.2
On 05/03/2010 01:04 PM, Ryota Ozaki wrote:
* src/util/cgroup.c: free temporal path string before breaking loop --- src/util/cgroup.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/util/cgroup.c b/src/util/cgroup.c index b649c3c..b8b2eb5 100644 --- a/src/util/cgroup.c +++ b/src/util/cgroup.c @@ -472,8 +472,10 @@ static int virCgroupMakeGroup(virCgroupPtr parent, virCgroupPtr group, int creat (i == VIR_CGROUP_CONTROLLER_CPUSET || STREQ(group->controllers[i].mountPoint, group->controllers[VIR_CGROUP_CONTROLLER_CPUSET].mountPoint))) { rc = virCgroupCpuSetInherit(parent, group); - if (rc != 0) + if (rc != 0) { + VIR_FREE(path); break; + }
ACK, after reading the entire function. I've pushed this commit; thanks again. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (2)
-
Eric Blake -
Ryota Ozaki