11:12 a.m.
cfg->firmwares still points to the original memory address after being
freed by virFirmwareFreeList(). As cfg get freed, it will be freed again
even if cfg->nfirmwares=0 which eventually lead to crash.
The patch fix it by setting cfg->firmwares to NULL explicitly after
virFirmwareFreeList() returns
Signed-off-by: Tuguoyi <tu.guoyi(a)h3c.com>
---
src/qemu/qemu_conf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 83de26a..98593b5 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
@@ -832,6 +832,7 @@ virQEMUDriverConfigLoadNVRAMEntry(virQEMUDriverConfigPtr cfg,
VIR_AUTOSTRINGLIST fwList = NULL;
virFirmwareFreeList(cfg->firmwares, cfg->nfirmwares);
+ cfg->firmwares = NULL;
if (qemuFirmwareFetchConfigs(&fwList, privileged) < 0)
return -1;
--
2.7.4
--
Best regards,
Guoyi
6:57 p.m.
On a Tuesday in 2020, Tuguoyi wrote:
cfg->firmwares still points to the original memory address after
being
freed by virFirmwareFreeList(). As cfg get freed, it will be freed again
even if cfg->nfirmwares=0 which eventually lead to crash.
The patch fix it by setting cfg->firmwares to NULL explicitly after
virFirmwareFreeList() returns
Signed-off-by: Tuguoyi <tu.guoyi(a)h3c.com>
Should there be a space separating your name(s)?
---
src/qemu/qemu_conf.c | 1 +
1 file changed, 1 insertion(+)
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano
9:42 a.m.
On a Tuesday in 2020, Ján Tomko wrote:
On a Tuesday in 2020, Tuguoyi wrote:
>cfg->firmwares still points to the original memory address after being
>freed by virFirmwareFreeList(). As cfg get freed, it will be freed again
>even if cfg->nfirmwares=0 which eventually lead to crash.
>
>The patch fix it by setting cfg->firmwares to NULL explicitly after
>virFirmwareFreeList() returns
>
>Signed-off-by: Tuguoyi <tu.guoyi(a)h3c.com>
Should there be a space separating your name(s)?
It can be changed to:
Signed-off-by: Guoyi Tu<tu.guoyi(a)h3c.com>
9:50 a.m.
-----Original Message-----
From: Ján Tomko [mailto:jtomko@redhat.com]
Sent: Tuesday, November 24, 2020 6:57 PM
To: tuguoyi (Cloud) <tu.guoyi(a)h3c.com>
Cc: libvir-list(a)redhat.com
Subject: Re: [PATCH] qemu_conf: Fix double free problem for cfg->firmwares
On a Tuesday in 2020, Tuguoyi wrote:
>cfg->firmwares still points to the original memory address after being
>freed by virFirmwareFreeList(). As cfg get freed, it will be freed again
>even if cfg->nfirmwares=0 which eventually lead to crash.
>
>The patch fix it by setting cfg->firmwares to NULL explicitly after
>virFirmwareFreeList() returns
>
>Signed-off-by: Tuguoyi <tu.guoyi(a)h3c.com>
Should there be a space separating your name(s)?
>---
> src/qemu/qemu_conf.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano
Hi there,
It's my first time to submit patch to libvirt, so I'm wondering will this patch be
applied to the upstream?
9:27 p.m.
On 12/1/20 2:50 AM, Tuguoyi wrote:
> -----Original Message-----
> From: Ján Tomko [mailto:jtomko@redhat.com]
> Sent: Tuesday, November 24, 2020 6:57 PM
> To: tuguoyi (Cloud) <tu.guoyi(a)h3c.com>
> Cc: libvir-list(a)redhat.com
> Subject: Re: [PATCH] qemu_conf: Fix double free problem for cfg->firmwares
>
> On a Tuesday in 2020, Tuguoyi wrote:
>> cfg->firmwares still points to the original memory address after being
>> freed by virFirmwareFreeList(). As cfg get freed, it will be freed again
>> even if cfg->nfirmwares=0 which eventually lead to crash.
>>
>> The patch fix it by setting cfg->firmwares to NULL explicitly after
>> virFirmwareFreeList() returns
>>
>> Signed-off-by: Tuguoyi <tu.guoyi(a)h3c.com>
>
> Should there be a space separating your name(s)?
>
>> ---
>> src/qemu/qemu_conf.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>
> Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
>
> Jano
Hi there,
It's my first time to submit patch to libvirt, so I'm wondering will this patch
be applied to the upstream?
Oh yeah, sorry. I've pushed it now:
https://gitlab.com/libvirt/libvirt/-/commit/c4f4e195a14c86b7daff2c45f1cbf...
Congratulations on your first libvirt contribution!
Michal
10:51 p.m.
On a Tuesday in 2020, Michal Privoznik wrote:
On 12/1/20 2:50 AM, Tuguoyi wrote:
>>-----Original Message-----
>>From: Ján Tomko [mailto:jtomko@redhat.com]
>>Sent: Tuesday, November 24, 2020 6:57 PM
>>To: tuguoyi (Cloud) <tu.guoyi(a)h3c.com>
>>Cc: libvir-list(a)redhat.com
>>Subject: Re: [PATCH] qemu_conf: Fix double free problem for cfg->firmwares
>>
>>On a Tuesday in 2020, Tuguoyi wrote:
>>>cfg->firmwares still points to the original memory address after being
>>>freed by virFirmwareFreeList(). As cfg get freed, it will be freed again
>>>even if cfg->nfirmwares=0 which eventually lead to crash.
>>>
>>>The patch fix it by setting cfg->firmwares to NULL explicitly after
>>>virFirmwareFreeList() returns
>>>
>>>Signed-off-by: Tuguoyi <tu.guoyi(a)h3c.com>
>>
>>Should there be a space separating your name(s)?
>>
>>>---
>>>src/qemu/qemu_conf.c | 1 +
>>>1 file changed, 1 insertion(+)
>>>
>>
>>Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
>>
>>Jano
>
>Hi there,
>
>It's my first time to submit patch to libvirt, so I'm wondering will this
patch be applied to the upstream?
>
Oh yeah, sorry. I've pushed it now:
Thank you,
Jano
https://gitlab.com/libvirt/libvirt/-/commit/c4f4e195a14c86b7daff2c45f1cbf...
Congratulations on your first libvirt contribution!
Michal
9:47 a.m.
-----Original Message-----
From: Michal Privoznik [mailto:mprivozn@redhat.com]
Sent: Tuesday, December 01, 2020 9:28 PM
To: tuguoyi (Cloud) <tu.guoyi(a)h3c.com>; Ján Tomko <jtomko(a)redhat.com>
Cc: libvir-list(a)redhat.com
Subject: Re: [PATCH] qemu_conf: Fix double free problem for cfg->firmwares
On 12/1/20 2:50 AM, Tuguoyi wrote:
>> -----Original Message-----
>> From: Ján Tomko [mailto:jtomko@redhat.com]
>> Sent: Tuesday, November 24, 2020 6:57 PM
>> To: tuguoyi (Cloud) <tu.guoyi(a)h3c.com>
>> Cc: libvir-list(a)redhat.com
>> Subject: Re: [PATCH] qemu_conf: Fix double free problem for
cfg->firmwares
>>
>> On a Tuesday in 2020, Tuguoyi wrote:
>>> cfg->firmwares still points to the original memory address after being
>>> freed by virFirmwareFreeList(). As cfg get freed, it will be freed again
>>> even if cfg->nfirmwares=0 which eventually lead to crash.
>>>
>>> The patch fix it by setting cfg->firmwares to NULL explicitly after
>>> virFirmwareFreeList() returns
>>>
>>> Signed-off-by: Tuguoyi <tu.guoyi(a)h3c.com>
>>
>> Should there be a space separating your name(s)?
>>
>>> ---
>>> src/qemu/qemu_conf.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>
>> Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
>>
>> Jano
>
> Hi there,
>
> It's my first time to submit patch to libvirt, so I'm wondering will this
patch
be applied to the upstream?
>
Oh yeah, sorry. I've pushed it now:
https://gitlab.com/libvirt/libvirt/-/commit/c4f4e195a14c86b7daff2c45f1cbfd2
3ac16aaa8
Congratulations on your first libvirt contribution!
Michal
Thanks a lot
1374
days inactive
1383
days old
6 comments
3 participants
participants (3)
-
Ján Tomko -
Michal Privoznik -
Tuguoyi