[libvirt] [jenkins-ci PATCH 0/2] CentOS fixes
This series consists in two simple patches: - Mention CentOS8 as a valid OS version; - Only install OpenVZ on CentOS 7; Fabiano Fidêncio (2): guests: Mention CentOS8 as a valid OS version guests: Only install OpenVZ on CentOS 7 guests/playbooks/update/tasks/base.yml | 1 + guests/vars/mappings.yml | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) -- 2.23.0
CentOS8 has been added as part of 03fd3a8ef16a3c4. However, it was not mentioned as a valid OS version. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> --- guests/vars/mappings.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index ef4e17a..c1a5d44 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -22,7 +22,8 @@ # - CentOS, Debian, Fedora, FreeBSD, OpenSUSE, Ubuntu # # Valid OS versions are: -# - CentOS7, Debian9, FedoraRawhide, OpenSUSE151, Ubuntu1804 and so on +# - CentOS7, CentOS8, Debian9, FedoraRawhide, OpenSUSE151, Ubuntu1804 and so +# on # # The arch specific rules use a prefix "$ARCH-" where $ARCH # is a libvirt arch name. -- 2.23.0
On Mon, 2019-12-16 at 12:55 +0100, Fabiano Fidêncio wrote:
# Valid OS versions are: -# - CentOS7, Debian9, FedoraRawhide, OpenSUSE151, Ubuntu1804 and so on +# - CentOS7, CentOS8, Debian9, FedoraRawhide, OpenSUSE151, Ubuntu1804 and so +# on
This list is intended to show what valid OS versions look like, not to provide a comprehensive list of all options - hence why it ends with "and so on". NACK -- Andrea Bolognani / Red Hat / Virtualization
OpenVZ has been added as part of commit 0a7993d3ed30ae. However, it's wrongly set to be installed on any supported CentOS. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> --- guests/playbooks/update/tasks/base.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/guests/playbooks/update/tasks/base.yml b/guests/playbooks/update/tasks/base.yml index f721e39..f085f19 100644 --- a/guests/playbooks/update/tasks/base.yml +++ b/guests/playbooks/update/tasks/base.yml @@ -50,6 +50,7 @@ group: root when: - os_name == 'CentOS' + - os_version == '7' - name: Update installed packages package: -- 2.23.0
On Mon, 2019-12-16 at 12:55 +0100, Fabiano Fidêncio wrote:
OpenVZ has been added as part of commit 0a7993d3ed30ae. However, it's wrongly set to be installed on any supported CentOS.
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> --- guests/playbooks/update/tasks/base.yml | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Andrea Bolognani <abologna@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization
participants (2)
-
Andrea Bolognani -
Fabiano Fidêncio