[libvirt] [PATCH 1/1] Make virtio as the default net device for PPC64
From: "Pradipta Kr. Banerjee" <bpradip@in.ibm.com> Make virtio as the default net device for PPC64 Signed-off-by: Pradipta Kr. Banerjee <bpradip@in.ibm.com> --- src/qemu/qemu_domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index e964c75..db36eff 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -790,7 +790,8 @@ static const char * qemuDomainDefaultNetModel(const virDomainDef *def) { if (def->os.arch == VIR_ARCH_S390 || - def->os.arch == VIR_ARCH_S390X) + def->os.arch == VIR_ARCH_S390X || + def->os.arch == VIR_ARCH_PPC64) return "virtio"; if (def->os.arch == VIR_ARCH_ARMV7L) { -- 1.8.3.1
On Thu, Dec 12, 2013 at 05:18:13PM +0530, Pradipta Kr. Banerjee wrote:
From: "Pradipta Kr. Banerjee" <bpradip@in.ibm.com>
Make virtio as the default net device for PPC64
Why ? Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On 12/12/2013 05:27 PM, Daniel P. Berrange wrote:
On Thu, Dec 12, 2013 at 05:18:13PM +0530, Pradipta Kr. Banerjee wrote:
From: "Pradipta Kr. Banerjee" <bpradip@in.ibm.com>
Make virtio as the default net device for PPC64
Why ? Hi Daniel, rtl8139 is not supported and maintained. Either of e1000, spapr-vlan or virtio are supported and improved upon. So its better to default to one of the above and virtio is the saner default.
Daniel
-- Regards, Pradipta
On Thu, Dec 12, 2013 at 05:43:27PM +0530, Pradipta Kumar Banerjee wrote:
On 12/12/2013 05:27 PM, Daniel P. Berrange wrote:
On Thu, Dec 12, 2013 at 05:18:13PM +0530, Pradipta Kr. Banerjee wrote:
From: "Pradipta Kr. Banerjee" <bpradip@in.ibm.com>
Make virtio as the default net device for PPC64
Why ? Hi Daniel, rtl8139 is not supported and maintained. Either of e1000, spapr-vlan or virtio are supported and improved upon. So its better to default to one of the above and virtio is the saner default.
IOW that has nothing todo with PPC64 architecture, which means that is not an acceptable reason to special case this for PPC64. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On 12/12/2013 05:48 PM, Daniel P. Berrange wrote:
On Thu, Dec 12, 2013 at 05:43:27PM +0530, Pradipta Kumar Banerjee wrote:
On 12/12/2013 05:27 PM, Daniel P. Berrange wrote:
On Thu, Dec 12, 2013 at 05:18:13PM +0530, Pradipta Kr. Banerjee wrote:
From: "Pradipta Kr. Banerjee" <bpradip@in.ibm.com>
Make virtio as the default net device for PPC64
Why ? Hi Daniel, rtl8139 is not supported and maintained. Either of e1000, spapr-vlan or virtio are supported and improved upon. So its better to default to one of the above and virtio is the saner default.
IOW that has nothing todo with PPC64 architecture, which means that is not an acceptable reason to special case this for PPC64.
My response was specific to ppc64. Sorry I should have put it clearly. rtl8139 is not supported and maintained for ppc64. It also lacks functionality like ppc64 guest network boot.
Daniel
-- Regards, Pradipta
participants (3)
-
Daniel P. Berrange -
Pradipta Kr. Banerjee -
Pradipta Kumar Banerjee