[libvirt] [PATCH] build: set --without-firewalld-zone in configure commandline for Fedora 30
The firewalld package in Fedora 30 didn't get support for rich rule priorities, which is required by the libvirt zonefile that's installed when the build is configured with --with-firewalld-zone, so we need to set --without-firewalld-zone for that version of Fedora. The needed feature is already upstream in firewalld, so it just needs another upstream release to be there. Let's be optimistic and assume that will happen prior to F31. Signed-off-by: Laine Stump <laine@laine.org> --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 8ea27c91a3..18f0a0e217 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -137,7 +137,7 @@ %define with_firewalld 1 -%if 0%{?fedora} >= 30 || 0%{?rhel} > 7 +%if 0%{?fedora} >= 31 || 0%{?rhel} > 7 %define with_firewalld_zone 0%{!?_without_firewalld_zone:1} %endif -- 2.20.1
On Thu, Apr 11, 2019 at 01:03:19PM -0400, Laine Stump wrote:
The firewalld package in Fedora 30 didn't get support for rich rule priorities, which is required by the libvirt zonefile that's installed when the build is configured with --with-firewalld-zone, so we need to set --without-firewalld-zone for that version of Fedora. The needed feature is already upstream in firewalld, so it just needs another upstream release to be there. Let's be optimistic and assume that will happen prior to F31.
Signed-off-by: Laine Stump <laine@laine.org> --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 8ea27c91a3..18f0a0e217 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -137,7 +137,7 @@
%define with_firewalld 1
-%if 0%{?fedora} >= 30 || 0%{?rhel} > 7 +%if 0%{?fedora} >= 31 || 0%{?rhel} > 7 %define with_firewalld_zone 0%{!?_without_firewalld_zone:1} %endif
Acked-by: Eric Garver <eric@garver.life>
On Thu, Apr 11, 2019 at 01:03:19PM -0400, Laine Stump wrote:
The firewalld package in Fedora 30 didn't get support for rich rule priorities, which is required by the libvirt zonefile that's installed when the build is configured with --with-firewalld-zone, so we need to set --without-firewalld-zone for that version of Fedora. The needed feature is already upstream in firewalld, so it just needs another upstream release to be there. Let's be optimistic and assume that will happen prior to F31.
Signed-off-by: Laine Stump <laine@laine.org> --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
participants (3)
-
Daniel P. Berrangé -
Eric Garver -
Laine Stump