[libvirt] [PATCH] remote: fix typo in remoteDomainOpenGraphicsFD

The remoteDomainOpenGraphicsFD method was using the wrong RPC arg struct remote_domain_open_graphics_args instead of remote_domain_open_graphics_fd_args. Fortunately both structs had identical contents so there was no functional bug, but to avoid consuing future maintainers, we should fix it. Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/remote/remote_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 273799b..5c4cf7c 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -6456,7 +6456,7 @@ remoteDomainOpenGraphicsFD(virDomainPtr dom, unsigned int flags) { int rv = -1; - remote_domain_open_graphics_args args; + remote_domain_open_graphics_fd_args args; struct private_data *priv = dom->conn->privateData; int *fdout = NULL; size_t fdoutlen = 0; -- 2.4.3

On Mon, Jul 27, 2015 at 10:31:07AM +0100, Daniel P. Berrange wrote:
The remoteDomainOpenGraphicsFD method was using the wrong RPC arg struct remote_domain_open_graphics_args instead of remote_domain_open_graphics_fd_args. Fortunately both structs had identical contents so there was no functional bug, but to avoid consuing future maintainers, we should fix it.
s/consuing/confusing/ ?
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/remote/remote_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK if you haven't pushed it already. Jan
participants (2)
-
Daniel P. Berrange
-
Ján Tomko