[Libvir] [PATCH] Add Xen Scheduler APIs to xenDaemonDriver
Hi, I add the Xen Scheduler APIs to xenDaemonDriver. - xenDaemonGetSchedulerType - xenDaemonGetSchedulerParameters - xenDaemonSetSchedulerParameters We will have the following improvements by this patch: 1) xenDaemonDriver of Schedulr is usable when xenHypervisorDriver failed. 2) Show the Scheduler information with non-root user. 3) Set the Scheduler parameters for inactive domain. (Unfortunately not right now, because we need this fix. http://lists.xensource.com/archives/html/xen-devel/2008-03/msg00301.html) And I have a few things to note: - Currently, implemented for the Xen-credit scheduler only. - xenDaemonGetSchedulerType is supported in xendConfigVersion >= 4, because we can get "xen_scheduler" from xend after Cset13394 of Xen (i.e. xendConfigVersion is four or later). - For the above reason, xenDaemonGetSchedulerParameters and xenDaemonSetSchedulerParameters are also supported in xendConfigVersion >= 4, because they are using xenDaemonGetSchedulerType to get the scheduler type. - At xenDaemonSetSchedulerParameters, there are restrictions which depends on Xend-version. a) We cannot set the "cap" value by xend before Cset15476 of Xen, because xend does not support the "cap" value at xend/server/SrvDomain.py b) We cannot set the scheduler parameters for inactive domain without the following patch. http://lists.xensource.com/archives/html/xen-devel/2008-03/msg00301.html If the above patch is committed, this API will be available for inactive domain. Regards, Saori Fukuta
On Thu, Mar 13, 2008 at 05:30:57PM +0900, Saori Fukuta wrote:
Hi,
I add the Xen Scheduler APIs to xenDaemonDriver.
I just applied the first patch about forbidding scheduler operations on read-only connections, that's simple and uncontroversial. I have not yet looked at the second patch, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
Hello, Thanks for applying the first patch (about adding read-only connections). http://git.et.redhat.com/?p=libvirt.git;a=commit;h=4faeb0d567976377b2661fb5e... How about the second one ? We can make some improvements for virsh schedinfo command with the patch, so I want the patch to be committed if it is OK. Regards, Saori Fukuta --- On Thu, 13 Mar 2008 17:30:57 +0900 Saori Fukuta wrote:
Hi,
I add the Xen Scheduler APIs to xenDaemonDriver. - xenDaemonGetSchedulerType - xenDaemonGetSchedulerParameters - xenDaemonSetSchedulerParameters We will have the following improvements by this patch: 1) xenDaemonDriver of Schedulr is usable when xenHypervisorDriver failed. 2) Show the Scheduler information with non-root user. 3) Set the Scheduler parameters for inactive domain. (Unfortunately not right now, because we need this fix. http://lists.xensource.com/archives/html/xen-devel/2008-03/msg00301.html)
And I have a few things to note: - Currently, implemented for the Xen-credit scheduler only. - xenDaemonGetSchedulerType is supported in xendConfigVersion >= 4, because we can get "xen_scheduler" from xend after Cset13394 of Xen (i.e. xendConfigVersion is four or later). - For the above reason, xenDaemonGetSchedulerParameters and xenDaemonSetSchedulerParameters are also supported in xendConfigVersion >= 4, because they are using xenDaemonGetSchedulerType to get the scheduler type. - At xenDaemonSetSchedulerParameters, there are restrictions which depends on Xend-version. a) We cannot set the "cap" value by xend before Cset15476 of Xen, because xend does not support the "cap" value at xend/server/SrvDomain.py b) We cannot set the scheduler parameters for inactive domain without the following patch. http://lists.xensource.com/archives/html/xen-devel/2008-03/msg00301.html If the above patch is committed, this API will be available for inactive domain.
Regards, Saori Fukuta
On Mon, Mar 24, 2008 at 02:12:25PM +0900, Saori Fukuta wrote:
Hello,
Thanks for applying the first patch (about adding read-only connections). http://git.et.redhat.com/?p=libvirt.git;a=commit;h=4faeb0d567976377b2661fb5e...
How about the second one ? We can make some improvements for virsh schedinfo command with the patch, so I want the patch to be committed if it is OK.
I had forgotten about it, sorry. It looks okay, though i have to clean a few problems raised by 'make syntax-check' (please try this in future patches). I commited it to CVS. However, i don't see why it is needed, basically when running with Xen as root, the hypervisor access should be used, not xend, so this seems to indicate that you have problem using the hypervisor calls and that's probably something to worry about. But it's fine having a more complete xend driver surrport. thanks, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
On Mon, 24 Mar 2008 05:27:04 -0400 Daniel Veillard wrote:
On Mon, Mar 24, 2008 at 02:12:25PM +0900, Saori Fukuta wrote:
How about the second one ? We can make some improvements for virsh schedinfo command with the patch, so I want the patch to be committed if it is OK.
I had forgotten about it, sorry. It looks okay, though i have to clean a few problems raised by 'make syntax-check' (please try this in future patches). I commited it to CVS.
Thank you for applying it. I will try "syntax-check" next time.
However, i don't see why it is needed, basically when running with Xen as root, the hypervisor access should be used, not xend, so this seems to indicate that you have problem using the hypervisor calls and that's probably something to worry about. But it's fine having a more complete xend driver surrport.
Yes, the hypervisor access should be used for root user. But if a domain is inactive, we cannot see/set the scheduler parameters with visrh command even though xm command can do it since we cannot access to the hypervisor. And also, we cannot allow to see the scheduler parameters for user who connect with read-only for the same reason. For such case, I thought we needed the patch to access with Xend driver. thanks a lot, Saori.
On Mon, Mar 24, 2008 at 07:37:51PM +0900, Saori Fukuta wrote:
Thank you for applying it. I will try "syntax-check" next time.
thanks :-)
However, i don't see why it is needed, basically when running with Xen as root, the hypervisor access should be used, not xend, so this seems to indicate that you have problem using the hypervisor calls and that's probably something to worry about. But it's fine having a more complete xend driver surrport.
Yes, the hypervisor access should be used for root user. But if a domain is inactive, we cannot see/set the scheduler parameters
hum, right i forgot the inactive domain problem.
with visrh command even though xm command can do it since we cannot access to the hypervisor. And also, we cannot allow to see the scheduler parameters for user who connect with read-only for the same reason.
Well read-only should still connect to the daemon, at least to read the status, the proxy mode should be deprecated, except for older setups.
For such case, I thought we needed the patch to access with Xend driver.
Okay, understood. But we have been bitten with the hypervisor being broken with xen-3.2 and not realizing it because things were done (in a far more expensive way) via xend. Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
participants (2)
-
Daniel Veillard -
Saori Fukuta