[Libvir] Support graphical console for PV Xen guests
With the paravirt framebuffer patches for Xen, we can support having a graphical console for PV as well as HVM guests. The attached adds support to libvirt by breaking out the <graphics> parsing into its own function that can be used by both PV and HVM guests. It also adds support for looking at the appropriate sexpr for the vnc/sdl console for PV guests. One thing that is potentially not okay is that I've changed sexpr_node to take a format string instead of just a const char *, but since it's not public API and doesn't actually change anything for callers I think it should be fine. If not, let me know and I can change it. Jeremy
On Sat, Aug 26, 2006 at 09:49:05AM -0400, Jeremy Katz wrote:
With the paravirt framebuffer patches for Xen, we can support having a graphical console for PV as well as HVM guests. The attached adds support to libvirt by breaking out the <graphics> parsing into its own function that can be used by both PV and HVM guests. It also adds support for looking at the appropriate sexpr for the vnc/sdl console for PV guests.
One thing that is potentially not okay is that I've changed sexpr_node to take a format string instead of just a const char *, but since it's not public API and doesn't actually change anything for callers I think it should be fine. If not, let me know and I can change it.
Honnestly I would prefer to add a new sexpr_fmt_node() routine with the snprintf call which would then call the old sexpr_node() and replace the few places where you need that functionality with call to sexpr_fmt_node. I'm just a bit afraid that people may not realize it's expanded that way and pass uncheck strings. Otherwise it just look fine, I can do the change or you can do it, either ways. thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
On Sat, 2006-08-26 at 10:18 -0400, Daniel Veillard wrote:
On Sat, Aug 26, 2006 at 09:49:05AM -0400, Jeremy Katz wrote:
With the paravirt framebuffer patches for Xen, we can support having a graphical console for PV as well as HVM guests. The attached adds support to libvirt by breaking out the <graphics> parsing into its own function that can be used by both PV and HVM guests. It also adds support for looking at the appropriate sexpr for the vnc/sdl console for PV guests.
One thing that is potentially not okay is that I've changed sexpr_node to take a format string instead of just a const char *, but since it's not public API and doesn't actually change anything for callers I think it should be fine. If not, let me know and I can change it.
Honnestly I would prefer to add a new sexpr_fmt_node() routine with the snprintf call which would then call the old sexpr_node() and replace the few places where you need that functionality with call to sexpr_fmt_node. I'm just a bit afraid that people may not realize it's expanded that way and pass uncheck strings.
Otherwise it just look fine, I can do the change or you can do it, either ways.
Simple enough, attached Jeremy
On Sat, Aug 26, 2006 at 10:27:38AM -0400, Jeremy Katz wrote:
On Sat, 2006-08-26 at 10:18 -0400, Daniel Veillard wrote:
On Sat, Aug 26, 2006 at 09:49:05AM -0400, Jeremy Katz wrote:
With the paravirt framebuffer patches for Xen, we can support having a graphical console for PV as well as HVM guests. The attached adds support to libvirt by breaking out the <graphics> parsing into its own function that can be used by both PV and HVM guests. It also adds support for looking at the appropriate sexpr for the vnc/sdl console for PV guests.
One thing that is potentially not okay is that I've changed sexpr_node to take a format string instead of just a const char *, but since it's not public API and doesn't actually change anything for callers I think it should be fine. If not, let me know and I can change it.
Honnestly I would prefer to add a new sexpr_fmt_node() routine with the snprintf call which would then call the old sexpr_node() and replace the few places where you need that functionality with call to sexpr_fmt_node. I'm just a bit afraid that people may not realize it's expanded that way and pass uncheck strings.
Otherwise it just look fine, I can do the change or you can do it, either ways.
Simple enough, attached
Okidoc :-) Applied ! thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
participants (2)
-
Daniel Veillard -
Jeremy Katz