[libvirt] [PATCH 0/1] Fix valgrind.supp path in Makefile.am

Hello, I'm Shotaro Gotanda from the University of Tokyo. I'm currently working toward GSOC'19, and creating several pathes for a bite-sized task. In that process, I encountered a problem in valgrind test. In detail, "make -C tests valgrind" failed with several cases even in master branch(commit 7a05c739c26decb8ff0eef4f6c75ce3ef729532d). I found a lot of error message like following in test-suite.log ==25680== FATAL: can't open suppressions file "./.valgrind.supp" This problem occurs in several environment; Lubuntu18.10(native), Ubuntu18.04(VM), Ubuntu16.04(VM). Though I have little idea about why this problem occured, the test succeeded with this patch. P.S. Because this is my first contribution to libvirt, I'm not familiar with reporting bugs, sending patches, and so on. So, I'll be so glad if you give me any feedback :) Shotaro Gotanda (1): tests: fix valgrind.supp path in Makefile tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.19.1

At the current time, several test case result in failure in "make -C tests valgrind". This commit fix the problem. Signed-off-by: Shotaro Gotanda <g.sho1500@gmail.com> --- tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 72f0420bab..97e61d9088 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -495,7 +495,7 @@ TESTS_ENVIRONMENT = \ VALGRIND = valgrind --quiet --leak-check=full --trace-children=yes \ --trace-children-skip="*/tools/virsh","*/tests/commandhelper" \ - --suppressions=$(srcdir)/.valgrind.supp + --suppressions=$(abspath $(srcdir))/.valgrind.supp valgrind: $(MAKE) check VG="$(LIBTOOL) --mode=execute $(VALGRIND)" -- 2.19.1

On 3/11/19 2:19 PM, Shotaro Gotanda wrote:
At the current time, several test case result in failure in "make -C tests valgrind". This commit fix the problem.
Signed-off-by: Shotaro Gotanda <g.sho1500@gmail.com> --- tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am index 72f0420bab..97e61d9088 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -495,7 +495,7 @@ TESTS_ENVIRONMENT = \
VALGRIND = valgrind --quiet --leak-check=full --trace-children=yes \ --trace-children-skip="*/tools/virsh","*/tests/commandhelper" \ - --suppressions=$(srcdir)/.valgrind.supp + --suppressions=$(abspath $(srcdir))/.valgrind.supp
We have abs_srcdir variable. I'm switching the code over to use that, fixing the commit message a bit, ACKing and pushing. Congratulations on your first libvirt contribution! Michal
participants (2)
-
Michal Privoznik
-
Shotaro Gotanda