[libvirt PATCH] Add .gitattributes file
The files marked as export-ignore here are not going to be included in the tarball produced by 'meson dist' when using meson >= 0.60. Older versions of meson excluded a small subset of these files automatically, but since we have more control now we can be more aggressive and leave out anything that doesn't make sense in a release tarball. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- .gitattributes | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 .gitattributes diff --git a/.gitattributes b/.gitattributes new file mode 100644 index 0000000000..6f0a34d2a0 --- /dev/null +++ b/.gitattributes @@ -0,0 +1,22 @@ +# Generic git stuff +**/.gitattributes export-ignore +**/.gitignore export-ignore +/.gitmodules export-ignore +/.mailmap export-ignore + +# Project-specific git stuff +/.gitpublish export-ignore +/docs/gitdm export-ignore +/docs/gitdm/** export-ignore +/gitdm.config export-ignore + +# Code hosting stuff +/.github export-ignore +/.github/** export-ignore +/.gitlab export-ignore +/.gitlab/** export-ignore + +# CI stuff +/.gitlab-ci.yml export-ignore +/ci export-ignore +/ci/** export-ignore -- 2.35.1
On 3/7/22 10:20, Andrea Bolognani wrote:
The files marked as export-ignore here are not going to be included in the tarball produced by 'meson dist' when using meson >= 0.60.
Older versions of meson excluded a small subset of these files automatically, but since we have more control now we can be more aggressive and leave out anything that doesn't make sense in a release tarball.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- .gitattributes | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 .gitattributes
Reviewed-by: Michal Privoznik <mprivozn@redhat.com> Michal
On a Monday in 2022, Andrea Bolognani wrote:
The files marked as export-ignore here are not going to be included in the tarball produced by 'meson dist' when using meson >= 0.60.
Older versions of meson excluded a small subset of these files automatically, but since we have more control now we can be more aggressive and leave out anything that doesn't make sense in a release tarball.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- .gitattributes | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 .gitattributes
Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano
On Mon, Mar 07, 2022 at 10:20:36AM +0100, Andrea Bolognani wrote:
The files marked as export-ignore here are not going to be included in the tarball produced by 'meson dist' when using meson >= 0.60.
Older versions of meson excluded a small subset of these files automatically, but since we have more control now we can be more aggressive and leave out anything that doesn't make sense in a release tarball.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- .gitattributes | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 .gitattributes
diff --git a/.gitattributes b/.gitattributes new file mode 100644 index 0000000000..6f0a34d2a0 --- /dev/null +++ b/.gitattributes @@ -0,0 +1,22 @@ +# Generic git stuff +**/.gitattributes export-ignore +**/.gitignore export-ignore +/.gitmodules export-ignore +/.mailmap export-ignore + +# Project-specific git stuff +/.gitpublish export-ignore +/docs/gitdm export-ignore +/docs/gitdm/** export-ignore +/gitdm.config export-ignore + +# Code hosting stuff +/.github export-ignore +/.github/** export-ignore +/.gitlab export-ignore +/.gitlab/** export-ignore + +# CI stuff +/.gitlab-ci.yml export-ignore +/ci export-ignore +/ci/** export-ignore
I don't think we should be excluding this. It is reasonable to want to use dockerfiles to setup an env for building from the tarball. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Mon, Mar 07, 2022 at 09:56:36AM +0000, Daniel P. Berrangé wrote:
On Mon, Mar 07, 2022 at 10:20:36AM +0100, Andrea Bolognani wrote:
+# CI stuff +/.gitlab-ci.yml export-ignore +/ci export-ignore +/ci/** export-ignore
I don't think we should be excluding this. It is reasonable to want to use dockerfiles to setup an env for building from the tarball.
Tarballs are going to be consumed primarily by distros and, to a much smaller extent, end users. I don't think Dockerfiles are going to be of much use in those scenarios and, in fact, we didn't include them in release tarballs until the switch to meson caused that to happen beyond our control. Since they add a non-trivial amount of clutter I'd rather see them gone. -- Andrea Bolognani / Red Hat / Virtualization
participants (4)
-
Andrea Bolognani -
Daniel P. Berrangé -
Ján Tomko -
Michal Prívozník