[libvirt] [PATCH] docs: comments wiping supported algorithms
The current scrub version doesn't support pfitzner7, pfitzner33 and schneier patterns on RHEL, we should comment it in virsh man page. * tools/virsh.pod: update wiping algorithms docs. Signed-off-by: Alex Jia <ajia@redhat.com> --- tools/virsh.pod | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index c306a38..eba9389 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -2081,6 +2081,8 @@ B<Supported algorithms> pfitzner33 - Roy Pfitzner's 33-random-pass method: random x33. random - 1-pass pattern: random. +B<Note>: Not all algorithms of wiping are expected to work, it depends on concrete B<srub> version. + =item B<vol-dumpxml> [I<--pool> I<pool-or-uuid>] I<vol-name-or-key-or-path> Output the volume information as an XML dump to stdout. -- 1.7.1
On 02/29/2012 04:02 PM, Alex Jia wrote:
The current scrub version doesn't support pfitzner7, pfitzner33 and schneier patterns on RHEL, we should comment it in virsh man page.
* tools/virsh.pod: update wiping algorithms docs.
Signed-off-by: Alex Jia<ajia@redhat.com> --- tools/virsh.pod | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod index c306a38..eba9389 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -2081,6 +2081,8 @@ B<Supported algorithms> pfitzner33 - Roy Pfitzner's 33-random-pass method: random x33. random - 1-pass pattern: random.
+B<Note>: Not all algorithms of wiping are expected to work, it depends on concrete B<srub> version. s/concrete/specific/, it should make more sense. + =item B<vol-dumpxml> [I<--pool> I<pool-or-uuid>] I<vol-name-or-key-or-path>
Output the volume information as an XML dump to stdout.
On Wed, Feb 29, 2012 at 04:13:52PM +0800, Alex Jia wrote:
On 02/29/2012 04:02 PM, Alex Jia wrote:
The current scrub version doesn't support pfitzner7, pfitzner33 and schneier patterns on RHEL, we should comment it in virsh man page.
* tools/virsh.pod: update wiping algorithms docs.
Signed-off-by: Alex Jia<ajia@redhat.com> --- tools/virsh.pod | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod index c306a38..eba9389 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -2081,6 +2081,8 @@ B<Supported algorithms> pfitzner33 - Roy Pfitzner's 33-random-pass method: random x33. random - 1-pass pattern: random.
+B<Note>: Not all algorithms of wiping are expected to work, it depends on concrete B<srub> version. s/concrete/specific/, it should make more sense.
ACK to that :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
On Wed, Feb 29, 2012 at 04:02:59PM +0800, Alex Jia wrote:
The current scrub version doesn't support pfitzner7, pfitzner33 and schneier patterns on RHEL, we should comment it in virsh man page.
* tools/virsh.pod: update wiping algorithms docs.
Signed-off-by: Alex Jia <ajia@redhat.com> --- tools/virsh.pod | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod index c306a38..eba9389 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -2081,6 +2081,8 @@ B<Supported algorithms> pfitzner33 - Roy Pfitzner's 33-random-pass method: random x33. random - 1-pass pattern: random.
+B<Note>: Not all algorithms of wiping are expected to work, it depends on concrete B<srub> version.
I'd word this slightly differently: B<note> the availability of algorithms may be limited by the version of the C<scrub> binary installed on the host. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On Wed, Feb 29, 2012 at 08:24:43AM +0000, Daniel P. Berrange wrote:
On Wed, Feb 29, 2012 at 04:02:59PM +0800, Alex Jia wrote:
The current scrub version doesn't support pfitzner7, pfitzner33 and schneier patterns on RHEL, we should comment it in virsh man page.
* tools/virsh.pod: update wiping algorithms docs.
Signed-off-by: Alex Jia <ajia@redhat.com> --- tools/virsh.pod | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod index c306a38..eba9389 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -2081,6 +2081,8 @@ B<Supported algorithms> pfitzner33 - Roy Pfitzner's 33-random-pass method: random x33. random - 1-pass pattern: random.
+B<Note>: Not all algorithms of wiping are expected to work, it depends on concrete B<srub> version.
I'd word this slightly differently:
B<note> the availability of algorithms may be limited by the version of the C<scrub> binary installed on the host.
yeah, that's really more precise :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
On Wed, Feb 29, 2012 at 04:02:59PM +0800, Alex Jia wrote:
The current scrub version doesn't support pfitzner7, pfitzner33 and schneier patterns on RHEL, we should comment it in virsh man page.
* tools/virsh.pod: update wiping algorithms docs.
Signed-off-by: Alex Jia<ajia@redhat.com> --- tools/virsh.pod | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod index c306a38..eba9389 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -2081,6 +2081,8 @@ B<Supported algorithms> pfitzner33 - Roy Pfitzner's 33-random-pass method: random x33. random - 1-pass pattern: random.
+B<Note>: Not all algorithms of wiping are expected to work, it depends on concrete B<srub> version. I'd word this slightly differently:
B<note> the availability of algorithms may be limited by the version of the C<scrub> binary installed on the host. I'd like this:-) thanks, I will follow the above modification and
On 02/29/2012 04:24 PM, Daniel P. Berrange wrote: directly push.
Regards, Daniel
participants (3)
-
Alex Jia -
Daniel P. Berrange -
Daniel Veillard