[Libvir] PATCH: Remove Xen Proxy driver
Since the previous patch allows the remote daemon to serve all the functions of the current Xen Proxy driver, this patch simply removes the Xen proxy and its driver. $ diffstat .hg/patches/remote-proxy Makefile.am | 2 a/proxy/.cvsignore | 5 a/proxy/Makefile.am | 19 a/proxy/libvirt_proxy.c | 852 ------------------------------------ a/src/proxy_internal.c | 1124 ------------------------------------------------ a/src/proxy_internal.h | 116 ---- src/Makefile.am | 1 src/xen_unified.c | 51 -- src/xen_unified.h | 9 9 files changed, 15 insertions(+), 2164 deletions(-) Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
On Wed, Sep 19, 2007 at 04:05:53AM +0100, Daniel P. Berrange wrote:
Since the previous patch allows the remote daemon to serve all the functions of the current Xen Proxy driver, this patch simply removes the Xen proxy and its driver.
Oh I should mention, I've only done minimal testing on this so far. I need to do more extensive testing to ensure I didn't miss any edge cases in the way apps were using the proxy. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
On Wed, Sep 19, 2007 at 04:08:50AM +0100, Daniel P. Berrange wrote:
On Wed, Sep 19, 2007 at 04:05:53AM +0100, Daniel P. Berrange wrote:
Since the previous patch allows the remote daemon to serve all the functions of the current Xen Proxy driver, this patch simply removes the Xen proxy and its driver.
Oh I should mention, I've only done minimal testing on this so far. I need to do more extensive testing to ensure I didn't miss any edge cases in the way apps were using the proxy.
Okay assuming we have the proper filtering of access in place, then this looks fine, it will also simplify the code. Documentation will also have to be revamped once the whole set of changes is in place, especially the architecture overview is now severely outdated and that's the last nail. Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
On Wed, Sep 19, 2007 at 06:22:58AM -0400, Daniel Veillard wrote:
On Wed, Sep 19, 2007 at 04:08:50AM +0100, Daniel P. Berrange wrote:
On Wed, Sep 19, 2007 at 04:05:53AM +0100, Daniel P. Berrange wrote:
Since the previous patch allows the remote daemon to serve all the functions of the current Xen Proxy driver, this patch simply removes the Xen proxy and its driver.
Oh I should mention, I've only done minimal testing on this so far. I need to do more extensive testing to ensure I didn't miss any edge cases in the way apps were using the proxy.
Just thinking about it, maybe test that the change doesn't end up doing too much performance degradation. For example if instead of doing RPC to proxy + hypercall, we end up doing RPC to daemon + PolicyKit (DBus RPC + lookup) + say xend access, this may introduce some regression. I assume all calls previously serviced by the proxy would still be allowed freely without PolicyKit checking, right ? Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
On Wed, Sep 19, 2007 at 06:27:39AM -0400, Daniel Veillard wrote:
On Wed, Sep 19, 2007 at 06:22:58AM -0400, Daniel Veillard wrote:
On Wed, Sep 19, 2007 at 04:08:50AM +0100, Daniel P. Berrange wrote:
On Wed, Sep 19, 2007 at 04:05:53AM +0100, Daniel P. Berrange wrote:
Since the previous patch allows the remote daemon to serve all the functions of the current Xen Proxy driver, this patch simply removes the Xen proxy and its driver.
Oh I should mention, I've only done minimal testing on this so far. I need to do more extensive testing to ensure I didn't miss any edge cases in the way apps were using the proxy.
Just thinking about it, maybe test that the change doesn't end up doing too much performance degradation. For example if instead of doing RPC to proxy + hypercall, we end up doing RPC to daemon + PolicyKit (DBus RPC + lookup) + say xend access, this may introduce some regression. I assume all calls previously serviced by the proxy would still be allowed freely without PolicyKit checking, right ?
I'll check the performance again. Last time I did this, using UNIX sockets with the remote driver was pretty damn good. The policykit DBus hit is a one-time hit when the socket is opened, so negligable & no impact per-RPC call. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
Daniel P. Berrange wrote:
Since the previous patch allows the remote daemon to serve all the functions of the current Xen Proxy driver, this patch simply removes the Xen proxy and its driver.
$ diffstat .hg/patches/remote-proxy Makefile.am | 2 a/proxy/.cvsignore | 5 a/proxy/Makefile.am | 19 a/proxy/libvirt_proxy.c | 852 ------------------------------------ a/src/proxy_internal.c | 1124 ------------------------------------------------ a/src/proxy_internal.h | 116 ---- src/Makefile.am | 1 src/xen_unified.c | 51 -- src/xen_unified.h | 9 9 files changed, 15 insertions(+), 2164 deletions(-)
Anything which removes the proxy driver has got to be +1. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903
participants (3)
-
Daniel P. Berrange -
Daniel Veillard -
Richard W.M. Jones