On Thu, Dec 18, 2008 at 05:35:28PM +0100, Daniel Veillard wrote:
On Thu, Dec 18, 2008 at 03:45:04PM +0100, Guido Günther wrote:
> On Thu, Dec 18, 2008 at 10:51:04AM +0000, Daniel P. Berrange wrote:
> > On Thu, Dec 18, 2008 at 10:26:07AM +0100, Guido G?nther wrote:
> > > Hi,
> > > due to some restructuring we free the device structure so devices are
> > > plugged correctly but "dumpxml" fails since the dev structure is
already
> >
> > This is a rather over complicated way of fixing it. Why not just
> > do:
> >
> > < cleanup:
> > < virDomainDeviceDefFree(dev)
> > -----------------
> > > cleanup:
> > > if (ret < 0)
> > > virDomainDeviceDefFree(dev);
> I somehow prefer to keep the cleanup and error targets different, but
> you're right the above is much simpler. Updated patch attached.
sure, +1,
Applied now.
-- Guido