[libvirt] [PATCH] spec: Enable sanlock on qemu_kvm_arches for RHEL

Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- libvirt.spec.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 76e57aa..c035c68 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -260,12 +260,12 @@ %endif # Enable sanlock library for lock management with QEMU -# Sanlock is available only on x86_64 for RHEL +# Sanlock is available only on arches where kvm is available for RHEL %if 0%{?fedora} >= 16 %define with_sanlock 0%{!?_without_sanlock:%{server_drivers}} %endif -%if 0%{?rhel} >= 6 - %ifarch x86_64 +%if 0%{?rhel} + %ifarch %{qemu_kvm_arches} %define with_sanlock 0%{!?_without_sanlock:%{server_drivers}} %endif %endif -- 2.0.2

On 07/23/2014 01:07 AM, Jiri Denemark wrote:
Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- libvirt.spec.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 76e57aa..c035c68 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -260,12 +260,12 @@ %endif
# Enable sanlock library for lock management with QEMU -# Sanlock is available only on x86_64 for RHEL +# Sanlock is available only on arches where kvm is available for RHEL %if 0%{?fedora} >= 16 %define with_sanlock 0%{!?_without_sanlock:%{server_drivers}} %endif -%if 0%{?rhel} >= 6 - %ifarch x86_64 +%if 0%{?rhel} + %ifarch %{qemu_kvm_arches} %define with_sanlock 0%{!?_without_sanlock:%{server_drivers}}
sanlock doesn't work on RHEL 5. I agree with the %ifarch line change, but think the %if 0%{?rhel} line should remain untouched. ACK with that fixed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

On Wed, Jul 23, 2014 at 07:39:50 -0600, Eric Blake wrote:
On 07/23/2014 01:07 AM, Jiri Denemark wrote:
Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- libvirt.spec.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 76e57aa..c035c68 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -260,12 +260,12 @@ %endif
# Enable sanlock library for lock management with QEMU -# Sanlock is available only on x86_64 for RHEL +# Sanlock is available only on arches where kvm is available for RHEL %if 0%{?fedora} >= 16 %define with_sanlock 0%{!?_without_sanlock:%{server_drivers}} %endif -%if 0%{?rhel} >= 6 - %ifarch x86_64 +%if 0%{?rhel} + %ifarch %{qemu_kvm_arches} %define with_sanlock 0%{!?_without_sanlock:%{server_drivers}}
sanlock doesn't work on RHEL 5. I agree with the %ifarch line change, but think the %if 0%{?rhel} line should remain untouched.
ACK with that fixed.
Right, I fixed that and pushed. Thanks, Jirka
participants (2)
-
Eric Blake
-
Jiri Denemark