[libvirt] [PATCH] Fix argument order at qemuMigrationPerformJob().

Hi, everyone. I found a small bug at qemuMigrationPerformJob(). The order of argument, @listenAddress and @cookiein, should be changed place, because these order are mismatched caller and callee. Signed-off-by: Minoru Usui <usui@mxm.nes.nec.co.jp> --- src/qemu/qemu_migration.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 9342062..53a4ae6 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -4045,8 +4045,8 @@ qemuMigrationPerformJob(virQEMUDriverPtr driver, const char *dconnuri, const char *uri, const char *graphicsuri, - const char *cookiein, const char *listenAddress, + const char *cookiein, int cookieinlen, char **cookieout, int *cookieoutlen, -- 1.7.2.3 -- Minoru Usui <usui@mxm.nes.nec.co.jp>

On 01/07/2014 02:03 AM, Minoru Usui wrote:
Hi, everyone.
I found a small bug at qemuMigrationPerformJob(). The order of argument, @listenAddress and @cookiein, should be changed place, because these order are mismatched caller and callee.
Signed-off-by: Minoru Usui <usui@mxm.nes.nec.co.jp> --- src/qemu/qemu_migration.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
ACK. This breaks the use of listen address for p2p migration and ignores the input cookie for migration protocols older than v3. Introduced along with the listen address parameter in c4ac7ef (describe --contains: v1.1.4-rc1~141). Jan

On 01/07/2014 10:00 AM, Ján Tomko wrote:
On 01/07/2014 02:03 AM, Minoru Usui wrote:
Hi, everyone.
I found a small bug at qemuMigrationPerformJob(). The order of argument, @listenAddress and @cookiein, should be changed place, because these order are mismatched caller and callee.
Signed-off-by: Minoru Usui <usui@mxm.nes.nec.co.jp> --- src/qemu/qemu_migration.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
ACK.
I have amended the commit message to include the bug I just filed for this [1] and pushed it. Thank you for the patch. Jan [1] https://bugzilla.redhat.com/show_bug.cgi?id=1049338
participants (2)
-
Ján Tomko
-
Minoru Usui