[libvirt] [PATCH] docs: bhyve: document recent changes

- mention that one disk and one network limitation is no longer actual for 1.2.6 and newer - add 'cdrom' device to the sample domain XML --- docs/drvbhyve.html.in | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/docs/drvbhyve.html.in b/docs/drvbhyve.html.in index e75eb83..9a97c57 100644 --- a/docs/drvbhyve.html.in +++ b/docs/drvbhyve.html.in @@ -42,9 +42,10 @@ in this sample domain XML. </p> <p> -A limitation that is not obvious from this sample domain XML is that currently only a -single network and a single disk device are supported for each domain (as PCI slot allocation code -in libvirt bhyve driver is yet to be implemented). +Note: an older versions of the libvirt bhyve driver had a limitation that only a +single network and a single disk device were supported for each domain. However, +<span class="since">since 1.2.6</span> the libvirt bhyve driver supports +up to 31 PCI devices. </p> <pre> @@ -71,6 +72,11 @@ in libvirt bhyve driver is yet to be implemented). <source file='/path/to/bhyve_freebsd.img'/> <target dev='hda' bus='sata'/> </disk> + <disk type='file' device='cdrom'> + <driver name='file' type='raw'/> + <source file='/path/to/cdrom.iso'/> + <target dev='hdc' bus='sata'/> + </disk> <interface type='bridge'> <model type='virtio'/> <source bridge="virbr0"/> -- 1.9.0

On 07/24/2014 05:54 PM, Roman Bogorodskiy wrote:
- mention that one disk and one network limitation is no longer actual for 1.2.6 and newer
s/actual/current/
- add 'cdrom' device to the sample domain XML --- docs/drvbhyve.html.in | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
ACK
diff --git a/docs/drvbhyve.html.in b/docs/drvbhyve.html.in index e75eb83..9a97c57 100644 --- a/docs/drvbhyve.html.in +++ b/docs/drvbhyve.html.in @@ -42,9 +42,10 @@ in this sample domain XML. </p>
<p> -A limitation that is not obvious from this sample domain XML is that currently only a -single network and a single disk device are supported for each domain (as PCI slot allocation code -in libvirt bhyve driver is yet to be implemented). +Note: an older versions of the libvirt bhyve driver had a limitation that only a +single network and a single disk device were supported for each domain. However,
s/an older/older/ s/network/network device/ reads better to me. or even simpler: Note: in older libvirt versions, only a single network device and a single disk device were supported per-domain.
+<span class="since">since 1.2.6</span> the libvirt bhyve driver supports +up to 31 PCI devices. </p>
<pre> @@ -71,6 +72,11 @@ in libvirt bhyve driver is yet to be implemented). <source file='/path/to/bhyve_freebsd.img'/> <target dev='hda' bus='sata'/> </disk> + <disk type='file' device='cdrom'> + <driver name='file' type='raw'/> + <source file='/path/to/cdrom.iso'/> + <target dev='hdc' bus='sata'/> + </disk> <interface type='bridge'> <model type='virtio'/> <source bridge="virbr0"/>

Ján Tomko wrote:
On 07/24/2014 05:54 PM, Roman Bogorodskiy wrote:
- mention that one disk and one network limitation is no longer actual for 1.2.6 and newer
s/actual/current/
- add 'cdrom' device to the sample domain XML --- docs/drvbhyve.html.in | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
ACK
diff --git a/docs/drvbhyve.html.in b/docs/drvbhyve.html.in index e75eb83..9a97c57 100644 --- a/docs/drvbhyve.html.in +++ b/docs/drvbhyve.html.in @@ -42,9 +42,10 @@ in this sample domain XML. </p>
<p> -A limitation that is not obvious from this sample domain XML is that currently only a -single network and a single disk device are supported for each domain (as PCI slot allocation code -in libvirt bhyve driver is yet to be implemented). +Note: an older versions of the libvirt bhyve driver had a limitation that only a +single network and a single disk device were supported for each domain. However,
s/an older/older/ s/network/network device/ reads better to me.
or even simpler:
Note: in older libvirt versions, only a single network device and a single disk device were supported per-domain.
Pushed with the suggested fixes, thanks! Roman Bogorodskiy
participants (2)
-
Ján Tomko
-
Roman Bogorodskiy