7:14 p.m.
Some time ago I went through the trouble to make support for perl module
requirements in our bootstrap. Even though we require it in the
bootstrap, it was not listed as a build requirement in the specfile.
Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
---
libvirt.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index cc5d72209873..b182f4521453 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -269,6 +269,7 @@ BuildRequires: /usr/bin/pod2man
%endif
BuildRequires: git
BuildRequires: perl
+BuildRequires: perl-XML-XPath
BuildRequires: python
%if %{with_systemd}
BuildRequires: systemd-units
--
2.9.2
7:20 p.m.
On Mon, Jul 25, 2016 at 01:14:47PM +0200, Martin Kletzander wrote:
Some time ago I went through the trouble to make support for perl
module
requirements in our bootstrap. Even though we require it in the
bootstrap, it was not listed as a build requirement in the specfile.
Yes, of course this is not reqiured since commit ad9e72f5fa11. This
patch wasn't meant to be sent to the ML. It also shows a mistake I bad
back in e9e5eee5a870. Anyway, disregard this patch, please.
Thanks,
Martin
7:24 p.m.
On Mon, Jul 25, 2016 at 01:14:47PM +0200, Martin Kletzander wrote:
Some time ago I went through the trouble to make support for perl
module
requirements in our bootstrap. Even though we require it in the
bootstrap, it was not listed as a build requirement in the specfile.
Is this required to build RPMs? From what I know we don't run bootstrap while
building RPMs from SRPM or from distributed archive where the generated
libvirt.spec file is and therefore this dependency is not required.
Pavel
8:16 p.m.
On Mon, Jul 25, 2016 at 01:24:07PM +0200, Pavel Hrdina wrote:
On Mon, Jul 25, 2016 at 01:14:47PM +0200, Martin Kletzander wrote:
> Some time ago I went through the trouble to make support for perl module
> requirements in our bootstrap. Even though we require it in the
> bootstrap, it was not listed as a build requirement in the specfile.
Is this required to build RPMs? From what I know we don't run bootstrap while
building RPMs from SRPM or from distributed archive where the generated
libvirt.spec file is and therefore this dependency is not required.
It's not required to do anything. It was used in hvsupport.pl before
Jan's rewrite, but it's not anymore. As I mentioned in my self-reply,
this was sent by mistake.
Martin
4:05 p.m.
On 25.07.2016 13:14, Martin Kletzander wrote:
Some time ago I went through the trouble to make support for perl
module
requirements in our bootstrap. Even though we require it in the
bootstrap, it was not listed as a build requirement in the specfile.
Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
---
libvirt.spec.in | 1 +
1 file changed, 1 insertion(+)
I wanted to do something similar quite a long time ago. Except adding
few more packages. My idea was to be able to rpmbuild the .spec file to
drag in all the deps for a build from git. It wasn't accepted as the
deps I was adding are not required to build RPM.
Now, every time I install fresh Fedora/RHEL I have to search for the
packages to install just to compile libvirt from git. Like a detection dog.
Michal
2996
days inactive
3003
days old
4 comments
3 participants
participants (3)
-
Martin Kletzander -
Michal Privoznik -
Pavel Hrdina