Do not store the return value of called functions in the same variable as the (future) return value of the current function. This makes tracking the origin of the value easier and reduces the chance of introducing a new point of exit without resetting the return value back to -1. --- src/storage/storage_backend.c | 13 +++++-------- src/uml/uml_driver.c | 5 ++--- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c index c07b642..231eccf 100644 --- a/src/storage/storage_backend.c +++ b/src/storage/storage_backend.c @@ -1963,26 +1963,23 @@ virStorageBackendVolZeroSparseFileLocal(virStorageVolDefPtr vol, off_t size, int fd) { - int ret = -1; - - ret = ftruncate(fd, 0); - if (ret == -1) { + if (ftruncate(fd, 0) < 0) { virReportSystemError(errno, _("Failed to truncate volume with " "path '%s' to 0 bytes"), vol->target.path); - return ret; + return -1; } - ret = ftruncate(fd, size); - if (ret == -1) { + if (ftruncate(fd, size) < 0) { virReportSystemError(errno, _("Failed to truncate volume with " "path '%s' to %ju bytes"), vol->target.path, (uintmax_t)size); + return -1; } - return ret; + return 0; } diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c index 3cfa36f..b0dba5c 100644 --- a/src/uml/uml_driver.c +++ b/src/uml/uml_driver.c @@ -1131,12 +1131,11 @@ static int umlStartVMDaemon(virConnectPtr conn, virCommandSetErrorFD(cmd, &logfd); virCommandDaemonize(cmd); - ret = virCommandRun(cmd, NULL); - if (ret < 0) + if (virCommandRun(cmd, NULL) < 0) goto cleanup; if (autoDestroy && - (ret = umlProcessAutoDestroyAdd(driver, vm, conn)) < 0) + umlProcessAutoDestroyAdd(driver, vm, conn) < 0) goto cleanup; ret = virDomainObjSetDefTransient(driver->caps, driver->xmlopt, vm, false); -- 2.4.10