[libvirt] Entering freeze for libvirt-1.3.1

As suggested this w.e., I just tagged the release candidate 1 in git and pushed signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ This works fine with my limited testing, but obviously more people need to give it some trial especially on other platforms. The output from CentOS CI is mostly green which is a good sign with just libvirt-daemon-rpm and virt-manager-test in the red, someone probably need to have a look before we release. The rc2 should come in 2 days on Thursday, and unless there is some blocker I plan to push 1.3.1 over the week-end, so please give it some testing ! Thanks, Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

On 12 Jan 2016, at 01:32, Daniel Veillard <veillard@redhat.com> wrote:
As suggested this w.e., I just tagged the release candidate 1 in git and pushed signed tarball and rpms to the usual place:
ftp://libvirt.org/libvirt/
This works fine with my limited testing, but obviously more people need to give it some trial especially on other platforms. The output from CentOS CI is mostly green which is a good sign with just libvirt-daemon-rpm and virt-manager-test in the red, someone probably need to have a look before we release.
The rc2 should come in 2 days on Thursday, and unless there is some blocker I plan to push 1.3.1 over the week-end,
Weirdly, it fails on OSX with the same error: ******************************************************************** Last 15 lines from /Users/jc/Library/Logs/Homebrew/libvirt/02.make: CCLD libvirt_driver_vbox.la CCLD libvirt_driver_storage.la Undefined symbols for architecture x86_64: "_xdr_uint64_t", referenced from: _xdr_virLogManagerProtocolLogFilePosition in virtlogd-log_protocol.o _xdr_virLogManagerProtocolDomainOpenLogFileRet in virtlogd-log_protocol.o _xdr_virLogManagerProtocolDomainGetLogFilePositionRet in virtlogd-log_protocol.o _xdr_virLogManagerProtocolDomainReadLogFileArgs in virtlogd-log_protocol.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) make[3]: *** [virtlogd] Error 1 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [all] Error 2 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 ******************************************************************** Was Roman's patch definitely pushed? Regards and best wishes, Justin Clift

Justin Clift wrote:
On 12 Jan 2016, at 01:32, Daniel Veillard <veillard@redhat.com> wrote:
As suggested this w.e., I just tagged the release candidate 1 in git and pushed signed tarball and rpms to the usual place:
ftp://libvirt.org/libvirt/
This works fine with my limited testing, but obviously more people need to give it some trial especially on other platforms. The output from CentOS CI is mostly green which is a good sign with just libvirt-daemon-rpm and virt-manager-test in the red, someone probably need to have a look before we release.
The rc2 should come in 2 days on Thursday, and unless there is some blocker I plan to push 1.3.1 over the week-end,
Weirdly, it fails on OSX with the same error:
********************************************************************
Last 15 lines from /Users/jc/Library/Logs/Homebrew/libvirt/02.make: CCLD libvirt_driver_vbox.la CCLD libvirt_driver_storage.la Undefined symbols for architecture x86_64: "_xdr_uint64_t", referenced from: _xdr_virLogManagerProtocolLogFilePosition in virtlogd-log_protocol.o _xdr_virLogManagerProtocolDomainOpenLogFileRet in virtlogd-log_protocol.o _xdr_virLogManagerProtocolDomainGetLogFilePositionRet in virtlogd-log_protocol.o _xdr_virLogManagerProtocolDomainReadLogFileArgs in virtlogd-log_protocol.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) make[3]: *** [virtlogd] Error 1 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [all] Error 2 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2
********************************************************************
Was Roman's patch definitely pushed?
Oops, it's my fault, I forgot to add the proper include for log protocol. Could you please try the attached patch? If you report it works I'll push it tomorrow as trivial if nobody has objections, it'd be good to have 1.3.1 working on OS X. Roman Bogorodskiy

On 12 Jan 2016, at 03:05, Roman Bogorodskiy <bogorodskiy@gmail.com> wrote: <snip>
Oops, it's my fault, I forgot to add the proper include for log protocol.
Could you please try the attached patch?
If you report it works I'll push it tomorrow as trivial if nobody has objections, it'd be good to have 1.3.1 working on OS X.
Still not quite there. ;) ************************************************************ Last 15 lines from /Users/jc/Library/Logs/Homebrew/libvirt/02.make: GEN logging/log_protocol.h GEN logging/log_daemon_dispatch_stubs.h GEN libvirt_access.xml GEN libvirt_access_qemu.xml GEN libvirt_access.syms GEN libvirt_access_qemu.syms GEN libvirt_access_lxc.syms unsigned hyper inode; ^^^^^^^^^^^^^^^^^^^^^^^^ logging/log_protocol.x, line 28: expected ';' cannot shutdown /usr/bin/rpcgen: at ./rpc/genprotocol.pl line 139. make[2]: *** [logging/log_protocol.h] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 ************************************************************ + Justin

Justin Clift wrote:
On 12 Jan 2016, at 03:05, Roman Bogorodskiy <bogorodskiy@gmail.com> wrote: <snip>
Oops, it's my fault, I forgot to add the proper include for log protocol.
Could you please try the attached patch?
If you report it works I'll push it tomorrow as trivial if nobody has objections, it'd be good to have 1.3.1 working on OS X.
Still not quite there. ;)
************************************************************ Last 15 lines from /Users/jc/Library/Logs/Homebrew/libvirt/02.make: GEN logging/log_protocol.h GEN logging/log_daemon_dispatch_stubs.h GEN libvirt_access.xml GEN libvirt_access_qemu.xml GEN libvirt_access.syms GEN libvirt_access_qemu.syms GEN libvirt_access_lxc.syms unsigned hyper inode; ^^^^^^^^^^^^^^^^^^^^^^^^ logging/log_protocol.x, line 28: expected ';' cannot shutdown /usr/bin/rpcgen: at ./rpc/genprotocol.pl line 139. make[2]: *** [logging/log_protocol.h] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2
************************************************************
That looks like the same issue with rpcgen that I've seen on OpenBSD. I don't know how to workaround that except building from a pre-created dist with those file pre-generated, such as if this patch will get in before rc2, most likely things will work if you download the libvirt-1.3.1-rc2.tar.gz and try to build it. Roman Bogorodskiy

Seems we don't have the fix for OSX/BSD in yet but I decided to push the new release candidate out, signed tarball and rpms are at the usual place, and it's tagged in git: ftp://libvirt.org/libvirt/ Seems to work for me but obviously more testing is better, I will also wait for the OSX/BSD patch to make a final release, if it's commited by this week-end I will push, otherwise this will have to wait Tuesday as I will be travelling Monday. So try it more and let's get a BSD patch in, thanks, Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

[trim libvirt-announce@] Daniel Veillard wrote:
Seems we don't have the fix for OSX/BSD in yet but I decided to push the new release candidate out, signed tarball and rpms are at the usual place, and it's tagged in git:
ftp://libvirt.org/libvirt/
Seems to work for me but obviously more testing is better, I will also wait for the OSX/BSD patch to make a final release, if it's commited by this week-end I will push, otherwise this will have to wait Tuesday as I will be travelling Monday.
So try it more and let's get a BSD patch in,
Actually we do have this patch in now (bc451c4). rc2 builds fine on my test OpenBSD install, I hope it does build on OS X also. These platforms are still affected by the rpcgen issue though, but it only affects people trying to do development builds (i.e. from a git repo, not from a tarball). Roman Bogorodskiy

On 15 Jan 2016, at 02:16, Roman Bogorodskiy <bogorodskiy@gmail.com> wrote:
[trim libvirt-announce@]
Daniel Veillard wrote:
Seems we don't have the fix for OSX/BSD in yet but I decided to push the new release candidate out, signed tarball and rpms are at the usual place, and it's tagged in git:
ftp://libvirt.org/libvirt/
Seems to work for me but obviously more testing is better, I will also wait for the OSX/BSD patch to make a final release, if it's commited by this week-end I will push, otherwise this will have to wait Tuesday as I will be travelling Monday.
So try it more and let's get a BSD patch in,
Actually we do have this patch in now (bc451c4).
rc2 builds fine on my test OpenBSD install, I hope it does build on OS X also.
These platforms are still affected by the rpcgen issue though, but it only affects people trying to do development builds (i.e. from a git repo, not from a tarball).
Yep, rc2 is compiling fine on OSX now too. Well, at least OSX 10.9.5 (my desktop). Didn't bother trying other versions. ;) + Justin

On Fri, Jan 15, 2016 at 08:17:43AM +0000, Justin Clift wrote:
On 15 Jan 2016, at 02:16, Roman Bogorodskiy <bogorodskiy@gmail.com> wrote:
[trim libvirt-announce@]
Daniel Veillard wrote:
Seems we don't have the fix for OSX/BSD in yet but I decided to push the new release candidate out, signed tarball and rpms are at the usual place, and it's tagged in git:
ftp://libvirt.org/libvirt/
Seems to work for me but obviously more testing is better, I will also wait for the OSX/BSD patch to make a final release, if it's commited by this week-end I will push, otherwise this will have to wait Tuesday as I will be travelling Monday.
So try it more and let's get a BSD patch in,
Actually we do have this patch in now (bc451c4).
rc2 builds fine on my test OpenBSD install, I hope it does build on OS X also.
These platforms are still affected by the rpcgen issue though, but it only affects people trying to do development builds (i.e. from a git repo, not from a tarball).
Yep, rc2 is compiling fine on OSX now too. Well, at least OSX 10.9.5 (my desktop). Didn't bother trying other versions. ;)
Ah excellent, thanks guys for the quick feedback ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

On Tue, Jan 12, 2016 at 09:32:35AM +0800, Daniel Veillard wrote:
As suggested this w.e., I just tagged the release candidate 1 in git and pushed signed tarball and rpms to the usual place:
ftp://libvirt.org/libvirt/
This works fine with my limited testing, but obviously more people need to give it some trial especially on other platforms. The output from CentOS CI is mostly green which is a good sign with just libvirt-daemon-rpm and virt-manager-test in the red, someone probably need to have a look before we release.
The rc2 should come in 2 days on Thursday, and unless there is some blocker I plan to push 1.3.1 over the week-end,
so please give it some testing !
A bit late since rc2 is already out but rc1 does good on Debian's buildds: https://buildd.debian.org/status/package.php?p=libvirt&suite=experimental CHeers, -- Guido
participants (4)
-
Daniel Veillard
-
Guido Günther
-
Justin Clift
-
Roman Bogorodskiy