[libvirt] [PATCH] Fix a comment typo in storage_backend_fs.c - Devel - Libvirt List Archives

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

December

[libvirt] [PATCH] Fix a comment typo in storage_backend_fs.c

[libvirt] Virtio Disk Drivers and...

[libvirt] VM image running on 2...

Cole Robinson

Tuesday, 28 April 2009 Tue, 28 Apr '09

11:33 a.m.

This comment hid from my attempt to 'grep FILE_BOCHS', which is the actual name of the constant. Thanks, Cole

Attachments:

libvirt-fix-comment-typo.patch (text/x-diff — 702 bytes)

Reply

Show replies by date

Daniel P. Berrange

Wednesday, 29 April Wed, 29 Apr

7:34 a.m.

On Tue, Apr 28, 2009 at 12:33:44PM -0400, Cole Robinson wrote:

This comment hid from my attempt to 'grep FILE_BOCHS', which is the actual name of the constant.

ACK

commit 62861e902fc3c272e46cdf9948079f12564ca119 Author: Cole Robinson <crobinso(a)redhat.com> Date: Wed Apr 22 14:51:54 2009 -0400 Update comment to reference correct volume format macro. diff --git a/src/storage_backend_fs.c b/src/storage_backend_fs.c index 29a644a..42c8c46 100644 --- a/src/storage_backend_fs.c +++ b/src/storage_backend_fs.c @@ -89,7 +89,7 @@ struct FileTypeInfo { struct FileTypeInfo const fileTypeInfo[] = { /* Bochs */ /* XXX Untested - { VIR_STORAGE_VOL_BOCHS, "Bochs Virtual HD Image", NULL, + { VIR_STORAGE_VOL_FILE_BOCHS, "Bochs Virtual HD Image", NULL, LV_LITTLE_ENDIAN, 64, 0x20000, 32+16+16+4+4+4+4+4, 8, 1, NULL },*/ /* CLoop */

Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

Reply

Cole Robinson

Monday, 4 May Mon, 4 May

10:45 a.m.

Daniel P. Berrange wrote:

On Tue, Apr 28, 2009 at 12:33:44PM -0400, Cole Robinson wrote: > This comment hid from my attempt to 'grep FILE_BOCHS', which is the > actual name of the constant. ACK > commit 62861e902fc3c272e46cdf9948079f12564ca119 > Author: Cole Robinson <crobinso(a)redhat.com> > Date: Wed Apr 22 14:51:54 2009 -0400 > > Update comment to reference correct volume format macro. > > diff --git a/src/storage_backend_fs.c b/src/storage_backend_fs.c > index 29a644a..42c8c46 100644 > --- a/src/storage_backend_fs.c > +++ b/src/storage_backend_fs.c > @@ -89,7 +89,7 @@ struct FileTypeInfo { > struct FileTypeInfo const fileTypeInfo[] = { > /* Bochs */ > /* XXX Untested > - { VIR_STORAGE_VOL_BOCHS, "Bochs Virtual HD Image", NULL, > + { VIR_STORAGE_VOL_FILE_BOCHS, "Bochs Virtual HD Image", NULL, > LV_LITTLE_ENDIAN, 64, 0x20000, > 32+16+16+4+4+4+4+4, 8, 1, NULL },*/ > /* CLoop */ Daniel

Thanks, committed. - Cole

Reply

5680

days inactive

5686

days old

devel@lists.libvirt.org

Manage subscription

2 comments

2 participants

tags (0)

participants (2)

Cole Robinson
Daniel P. Berrange