[libvirt] [PATCH] Align vol-resize arguments with the output of help
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- tools/virsh.pod | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index d1030808a3ed..34679e363a8e 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -4025,12 +4025,12 @@ I<--pool> I<pool-or-uuid> is the name or UUID of the storage pool the volume is in. I<vol-name-or-path> is the name or path of the volume to return the volume key for. -=item B<vol-resize> [I<--pool> I<pool-or-uuid>] I<vol-name-or-path> -I<pool-or-uuid> I<capacity> [I<--allocate>] [I<--delta>] [I<--shrink>] +=item B<vol-resize> I<vol-name-or-path> I<capacity> [I<--pool> I<pool-or-uuid>] +[I<--allocate>] [I<--delta>] [I<--shrink>] Resize the capacity of the given volume, in bytes. I<--pool> I<pool-or-uuid> is the name or UUID of the storage pool the volume -is in. I<vol-name-or-key-or-path> is the name or key or path of the volume +is in. I<vol-name-or-path> is the name or key or path of the volume to resize. The new capacity might be sparse unless I<--allocate> is specified. Normally, I<capacity> is the new size, but if I<--delta> is present, then it is added to the existing size. Attempts to shrink -- 2.12.2
On Wed, Apr 12, 2017 at 08:59:36AM +0200, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- tools/virsh.pod | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
I forgot to prefix the subject with 'man:', I already fixed it locally, though.
diff --git a/tools/virsh.pod b/tools/virsh.pod index d1030808a3ed..34679e363a8e 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -4025,12 +4025,12 @@ I<--pool> I<pool-or-uuid> is the name or UUID of the storage pool the volume is in. I<vol-name-or-path> is the name or path of the volume to return the volume key for.
-=item B<vol-resize> [I<--pool> I<pool-or-uuid>] I<vol-name-or-path> -I<pool-or-uuid> I<capacity> [I<--allocate>] [I<--delta>] [I<--shrink>] +=item B<vol-resize> I<vol-name-or-path> I<capacity> [I<--pool> I<pool-or-uuid>] +[I<--allocate>] [I<--delta>] [I<--shrink>]
Resize the capacity of the given volume, in bytes. I<--pool> I<pool-or-uuid> is the name or UUID of the storage pool the volume -is in. I<vol-name-or-key-or-path> is the name or key or path of the volume +is in. I<vol-name-or-path> is the name or key or path of the volume to resize. The new capacity might be sparse unless I<--allocate> is specified. Normally, I<capacity> is the new size, but if I<--delta> is present, then it is added to the existing size. Attempts to shrink -- 2.12.2
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Wed, Apr 12, 2017 at 08:59:36AM +0200, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- tools/virsh.pod | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod index d1030808a3ed..34679e363a8e 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -4025,12 +4025,12 @@ I<--pool> I<pool-or-uuid> is the name or UUID of the storage pool the volume is in. I<vol-name-or-path> is the name or path of the volume to return the volume key for.
-=item B<vol-resize> [I<--pool> I<pool-or-uuid>] I<vol-name-or-path> -I<pool-or-uuid> I<capacity> [I<--allocate>] [I<--delta>] [I<--shrink>] +=item B<vol-resize> I<vol-name-or-path> I<capacity> [I<--pool> I<pool-or-uuid>] +[I<--allocate>] [I<--delta>] [I<--shrink>]
Resize the capacity of the given volume, in bytes. I<--pool> I<pool-or-uuid> is the name or UUID of the storage pool the volume -is in. I<vol-name-or-key-or-path> is the name or key or path of the volume +is in. I<vol-name-or-path> is the name or key or path of the volume
If you are removing the *key* from the argument name i would go further and remove also the *path* and in that case it would be nice to remove *uuid* from the pool argument name. However, we have these long argument names for other volume/pool commands so it should be probably done in a separate patch. ACK to the argument order change but for the argument name change please send separate patch. Pavel
to resize. The new capacity might be sparse unless I<--allocate> is specified. Normally, I<capacity> is the new size, but if I<--delta> is present, then it is added to the existing size. Attempts to shrink -- 2.12.2
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Wed, Apr 12, 2017 at 09:58:13AM +0200, Pavel Hrdina wrote:
On Wed, Apr 12, 2017 at 08:59:36AM +0200, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- tools/virsh.pod | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod index d1030808a3ed..34679e363a8e 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -4025,12 +4025,12 @@ I<--pool> I<pool-or-uuid> is the name or UUID of the storage pool the volume is in. I<vol-name-or-path> is the name or path of the volume to return the volume key for.
-=item B<vol-resize> [I<--pool> I<pool-or-uuid>] I<vol-name-or-path> -I<pool-or-uuid> I<capacity> [I<--allocate>] [I<--delta>] [I<--shrink>] +=item B<vol-resize> I<vol-name-or-path> I<capacity> [I<--pool> I<pool-or-uuid>] +[I<--allocate>] [I<--delta>] [I<--shrink>]
Resize the capacity of the given volume, in bytes. I<--pool> I<pool-or-uuid> is the name or UUID of the storage pool the volume -is in. I<vol-name-or-key-or-path> is the name or key or path of the volume +is in. I<vol-name-or-path> is the name or key or path of the volume
If you are removing the *key* from the argument name i would go further and remove also the *path* and in that case it would be nice to remove *uuid* from the pool argument name. However, we have these long argument names for other volume/pool commands so it should be probably done in a separate patch.
That's precisely why I just made it aligned with other commands, removing all of them is totally different thing.
ACK to the argument order change but for the argument name change please send separate patch.
I honestly can't be bothered (and I don't even feel sorry). I'll just keep the part you ACKed then and put the 'or key' back.
Pavel
to resize. The new capacity might be sparse unless I<--allocate> is specified. Normally, I<capacity> is the new size, but if I<--delta> is present, then it is added to the existing size. Attempts to shrink -- 2.12.2
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
participants (2)
-
Martin Kletzander -
Pavel Hrdina