[libvirt] [PATCH 5/7] VMware ESX: Add esxGetCapabilities() with basic default capabilities
* src/esx/esx_driver.c: add esxCapsInit() with default caps and add esxGetCapabilities()
On Thu, Sep 03, 2009 at 06:45:44PM +0200, Matthias Bolte wrote:
* src/esx/esx_driver.c: add esxCapsInit() with default caps and add esxGetCapabilities()
Hum ... That one looks really incomplete. Does it really make sense to implement it just based on pure default without asking the ESX about it's capabilities ? I think it should be applied because of the MAC prefix and AddHostMigrateTransport hints but the capabilities themselves look a bit misleading. I'm applying but it really seems this need more work, right ? ;-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
2009/9/4 Daniel Veillard <veillard@redhat.com>:
On Thu, Sep 03, 2009 at 06:45:44PM +0200, Matthias Bolte wrote:
* src/esx/esx_driver.c: add esxCapsInit() with default caps and add esxGetCapabilities()
Hum ... That one looks really incomplete. Does it really make sense to implement it just based on pure default without asking the ESX about it's capabilities ? I think it should be applied because of the MAC prefix and AddHostMigrateTransport hints but the capabilities themselves look a bit misleading.
I'm applying but it really seems this need more work, right ? ;-)
Yes, this is incomplete. I've a patch that adds x86_64 vs. i686 detection based on the CPUID. I also have patches for VMX to domain XML mapping including a bunch of test for VMX <-> domain XML mapping, but they need some cleanup before I'll post them. Matthias
On Fri, Sep 04, 2009 at 06:49:32PM +0200, Matthias Bolte wrote:
2009/9/4 Daniel Veillard <veillard@redhat.com>:
On Thu, Sep 03, 2009 at 06:45:44PM +0200, Matthias Bolte wrote:
* src/esx/esx_driver.c: add esxCapsInit() with default caps and add esxGetCapabilities()
Hum ... That one looks really incomplete. Does it really make sense to implement it just based on pure default without asking the ESX about it's capabilities ? I think it should be applied because of the MAC prefix and AddHostMigrateTransport hints but the capabilities themselves look a bit misleading.
I'm applying but it really seems this need more work, right ? ;-)
Yes, this is incomplete. I've a patch that adds x86_64 vs. i686 detection based on the CPUID. I also have patches for VMX to domain XML mapping including a bunch of test for VMX <-> domain XML mapping, but they need some cleanup before I'll post them.
Okay, just checking :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
participants (2)
-
Daniel Veillard -
Matthias Bolte